Feature #3189 and #3194 - pb2nc quality mark thresh and grid_diag mask and output_flag - #3201
Conversation
…stead of just integers. Added unit test to demonstrate newly supported format
…esn't apply to all developers
…ple masking regions
… that doesn't apply to all developers" This reverts commit 8222bcb.
Pull Request Test Coverage Report for Build 21636391197Details
💛 - Coveralls |
JohnHalleyGotway
left a comment
There was a problem hiding this comment.
Recommend removing the .idea directory and files from this PR. Apparently those are artifacts of JetBrains IDE's. You could consider adding .idea to the .gitignore file as well.
|
@JohnHalleyGotway, I have received mixed messages about best practices for ignorning .idea files. It had previously been suggested to only ignore |
JohnHalleyGotway
left a comment
There was a problem hiding this comment.
Looks great. I approve. Thanks.
Pull Request Testing
Added unit tests to demonstrate setting new config settings
Review code/doc changes, ensure automated tests pass (met_tool_wrapper has a 1 diff file from an unrelated MET PR)
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Note the ioda2nc changes have not yet been made in MET, so setting a threshold value for
quality_mark_threshin ioda2nc will cause a failure in MET until this is implementedWill this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by 2/3/2026.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases