Repository navigation
docs: doc-review 2026-10-15 — AI console page actions, AI-assisted noise reduction, service-calendar/CLI/SDK drift - #1057
Closed
flashduty[bot] wants to merge 1 commit into
Closed
flashduty[bot] wants to merge 1 commit into
flashduty[bot] wants to merge 1 commit into
Conversation
…ise reduction, and service-calendar/CLI/SDK drift Window: 2026-10-14T08:01:57Z (last successful run) → 2026-10-15T08:00Z. 36 findings across 22 source repos → 20 doc pages updated (zh + en). Highlights: - ai-sre/sessions: new 操作控制台页面 section (page-declared actions, park/resume, two-layer consent, read vs write) — previously undocumented everywhere. - on-call/channel/noise-reduction: 「让 AI 帮你配置降噪」 entry and the channel-noise skill. - ai-sre/skills: channel-noise added to the built-in skill enumeration. - changelog: new 2026-10-15 entry; corrected the 2026-10-14 dashboard-search and investigation-entry wording that this window's code moved under. - Developer: curated `calendar` subsection, release_limited, work-item status enum, third generated-output bound class, Go SDK service-calendar behaviour. - Monitors / RUM / platform / DataWorks detail fixes. mint broken-links: success no broken links found.
5 tasks
Contributor
|
Superseded by #1070, which re-applies the still-relevant parts of this PR on current main (see the table there for what was ported and what was left out). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc Review — 2026-10-15
Mode: diff — window
2026-10-14T08:01:57Z(last successful run) →2026-10-15T08:00ZFindings: 36 total — 4 high, 11 medium, 21 low
Source repos scanned (22): fc-event, fc-oncall, fc-foundation-app, flashduty-app, fc-datasource, fc-pgy, fc-rum, monit-webapi, monit-edge, fc-statuspage, flashduty-mcp-server, terraform-provider-flashduty, fc-safari, flashduty-runner, flashduty-cli, go-flashduty, flashduty-website, and the fc-foundation-app submodules fc-saas-web, fc-saas-monit, ai-sre-web, fc-saas-rum, ai-assistant-web.
Repos with no commits in the window: fc-oncall, flashduty-app, monit-webapi, flashduty-mcp-server, terraform-provider-flashduty, flashduty-runner, flashduty-website, ai-assistant-web.
Changes
on-call/channel/noise-reduction.mdx/channel-noiserequest, 3-step flow, confirm-before-write, group/flapping-only scopeai-sre/sessions.mdxai-sre/sessions.mdxfdutybypass on a form pageai-sre/sessions.mdxchangelog/changelog.mdxon-call/configuration/service-calendar.mdxon-call/integration/alert-integration/alert-sources/aliyun-dataworks-op.mdx## 标签label-mapping section to zh; corrected 6 inaccurate rows + added the empty-label/title facts to enmonitors/alert-rules/investigation-entries.mdxmonitors/dashboards/dashboards.mdxmonitors/dashboards/dashboards.mdxai-sre/skills.mdxchannel-noiseto the 内置 Skill table plus a subsection on its entry-only trigger and write scopeai-sre/sessions.mdxchannel_noiseentry to 上下文引用ai-sre/sessions.mdxdeveloper/cli.mdx### calendar — 服务日历subsection (range-clear delete, upsert trim,daysresolved map)developer/go-sdk.mdx### 服务日历事件behaviour note (range clear, upsert carve,Days/CalDaylayer precedence)ai-sre/sessions.mdxchannel_noisecontext reference (type, entry, prefilled question)on-call/configuration/service-calendar.mdxon-call/configuration/service-calendar.mdxon-call/configuration/service-calendar.mdxon-call/configuration/service-calendar.mdxon-call/channel/create-edit.mdxrum/quickstart/app-management.mdxmonitors/alert-rules/investigation-entries.mdxmonitors/alert-rules/investigation-entries.mdxmonitors/folders/folders.mdxmonitors/dashboards/dashboards.mdxmonitors/dashboards/dashboards.mdxmonitors/dashboards/dashboards.mdxmonitors/explore/explore.mdxmonitors/engine/engine-lost-alert.mdxai-sre/sessions.mdxfunction_response+function_responses; same fix in zh/enopenapi/api-catalog.mdxdeveloper/cli.mdxrelease_limitedsentence to the oncalllicense-listdescriptiondeveloper/cli.mdxdeveloper/cli.mdxAlso in the response:line and the third output-bound classdeveloper/go-sdk.mdxrum/explorer/data-query.mdx字段:*(field exists / IS NOT NULL) row to the attribute-search tableReview checklist
en/file is a faithful translation of itszh/counterpart (zh is the source of truth)Cross-repo follow-ups (flashduty-website)
None.
flashduty-websitehad no commits in this window. The integrations catalog (lib/integrations/catalog.ts, 346 entries) already listsaliyun-dataworks-op, and every "60+" integration-count claim inmessages/zh.json/messages/en.jsonstill holds.Handed to the api-reference automation (api-review) — not edited here
api-reference/*.openapi.{zh,en}.json(split) andapi-reference/openapi.{zh,en}.json(consolidated) are generated and owned by the api-review daily audit, so these two were reported rather than patched:POST /rum/data/query— the operation now enforces per-application read access and caps a request at 50 applications (fc-rumcmd/server/controller/data/access.go,maxApplicationsPerRequest = 50, called bydata/query.gobefore any query runs). Its 限制说明 still says 「权限要求 无」 and lists only 400/401/429/500; 403/404 are now reachable and should be listed. (rum-apif001)fc-rumlogic/ast/sql/sql.go(thesubquery_test.goasserts refusal, not support). This is a newly rejected construct on the publicsqlfield used by/rum/data/queryand/rum/facet/count, and no API-reference or prose page documents the restriction. (rum-astf001)A third item, also api-reference-only:
api-reference/on-call.openapi.{zh,en}.jsonstill describes work-itemtarget_statusas "client-defined string — no fixed state machine", while the Go SDK and CLI now treat it as the closed enumopen|in_progress|done|cancelled. The prose fix landed here (f033,f035).Mapping warnings
None. All 97 mapped source paths in
mapping.yamlresolve againstorigin/main, including the submodule-aware check forsrc/Packages/{saas,monit,rum,ai-sre,ai-assistant}. No repo was missing and none failed to clone.Skipped
Two Phase-1 findings were dropped before the fix pass, and no Phase-2 worker returned a SKIPPED:
zh|en/ai-sre/sessions.mdx): the docs list 「定时自动巡检」 as one of the four default scenario cards, but the code's fourth default is 「自动分析新故障」 and 定时自动巡检 lives in the 更多 dropdown. Real drift, but not introduced in this window — the diff only changed icon colour classes and the container width on that file — so it belongs to a backlog pass, not this PR./rum/data/queryOpenAPI limits — moved into the api-review hand-off above instead of being edited inline.Notes for the reviewer
f025originally claimed a same-named rule in the target folder surfaces as the移动失败toast. It does not:monit-webapi logic/logic_alert_rule.goMoveRulereturns HTTP 200 with a per-rule message list, and the frontend only toasts移动失败when the request itself rejects. So the rule is silently skipped while移动成功still shows. The docs here state only that the rule is not moved — worth a product ticket, not a docs fix.f020suggested describing the new day-cell ring as 蓝色边框.ring-primaryresolves to the brand purple token, not blue, so the text says 额外描一圈边框 without naming a colour.ai-sre/sessions.mdx,ai-sre/skills.mdx,developer/cli.mdx,monitors/dashboards/dashboards.mdxandchangelog.mdx— the same files this PR touches, but different sections (子代理汇报 / 子任务, 上传 Skill toolbar, 全局参数 table +alert events+ 时间窗口提示, the 全屏与查询详情 panel hover, and the 2026-10-12 entry). Expect merge conflicts on those files; the content does not overlap.mint broken-links→success no broken links found(re-run on the frozen tree).