Repository navigation
Fix crash with --instructions and --instructions-deploy - #155
Merged
Merged
Conversation
kylemclaren
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #144.
Problem
--instructions-deploy=<file>and its alias--instructions=<file>crash before generating anything:instructionsis also a key indefaults(the{ base, build, deploy }object). Because yargs sets the alias key too,options.instructionsbecomes the file name string. The loop that copies changed defaults intopackage.jsonthen writesdockerfile.instructions = "<file>". The per-stage code a few lines later doesdf.instructions[stage] = ...on that string and throws.--instructions-baseand--instructions-buildhave no alias, so they work.Change
Skip
instructionsin the defaults loop. The per-stage loop below it already readsoptions['instructions-<stage>']and maintainsdockerfile.instructionsinpackage.json, so nothing else needs to change.Testing
In a scratch app with
package.jsonanddeploy.txtcontainingRUN echo hi:--instructions-deploy=deploy.txt: crashed onmain. Now exits 0, the Dockerfile containsRUN echo hi, andpackage.jsongets"dockerfile": {"instructions": {"deploy": "deploy.txt"}}.--instructions=deploy.txt: same result.--instructions=removes them from the Dockerfile and frompackage.json.eslintclean.npm test: 126 passing, 3 failing (bun base/cache-bun, svelte-bun), the same 3 that fail onmainwithout bun installed.🤖 Generated with Claude Code