Skip to content

Fix crash with --instructions and --instructions-deploy #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kylemclaren merged 1 commit into from
Oct 22, 2026
Merged

Fix crash with --instructions and --instructions-deploy #155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,9 @@ if (pj) {
pj.dockerfile ||= {}

for (const prop in defaults) {
// --instructions is an alias for --instructions-deploy, handled below
if (prop === 'instructions') continue

if (prop in options && options[prop] !== pj.dockerfile[prop]) {
if (options[prop] === defaults[prop]) {
delete pj.dockerfile[prop]
Expand Down
Loading