Repository navigation
Conversation
The iOS job ran the device tests and then the integration tests on one Mac, about 42 minutes in all. The two build and run different apps and share only the simulator, so the integration tests now run in a second job at the same time. ios.Tests.ps1 skips every case unless a simulator is already booted, and xharness only boots one in the ios-tests job, so the new job boots its own. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5790 +/- ##
==========================================
- Coverage 76.13% 76.11% -0.02%
==========================================
Files 528 528
Lines 19579 19579
Branches 3829 3829
==========================================
- Hits 14906 14903 -3
- Misses 3791 3793 +2
- Partials 882 883 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The boot takes about 2 minutes. Without a limit, a hung boot would run until the job's 6-hour timeout. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iOS Device Tests job is now the slowest check on a PR. In the combined measurement on #5788, the build workflow finished in 35 minutes and the iOS job took about 42.
It does everything in sequence on one Mac:
The device tests and the integration tests build and run different apps,
Sentry.Maui.Device.TestAppandSentry.Maui.Device.IntegrationTestApp. They only share the simulator. So this PR movesios.Tests.ps1into a second job,ios-integration-tests, which starts at the same time on its own Mac.ios.Tests.ps1skips every case unless a simulator is already booted. Inios-testsxharness boots it, so the new job boots its own with the sameGet-IosSimulatorUdidhelper andsimctl bootstatus -b. The boot takes about 2 minutes, and the step times out after 10, so a hung boot can't hold the job for hours.device-test-ios-resultsanddevice-test-ios-integration-results.I expect the iOS workflow to drop from about 42 to about 25 minutes, so a PR waits on the build workflow again. The cost is one more Mac per run, about 8 more macOS minutes for its setup and simulator boot.
Measured on the first run, against #5792's run from the same evening, which still runs both steps in one job:
ios-testsios-integration-testsAll 8 integration cases ran: "Discovery found 8 tests" and "Tests Passed: 8, Failed: 0, Skipped: 0". The combined draft #5793 matched this, with the iOS workflow at 16.6 minutes and 8 of 8 passed.
#skip-changelog