Skip to content

fix: allow an escaped backslash at the end of a Value regex - #154

Open
OverloadedTech wants to merge 1 commit into
google:masterfrom
OverloadedTech:fix-value-trailing-backslash
Open

OverloadedTech wants to merge 1 commit into
google:masterfrom
OverloadedTech:fix-value-trailing-backslash

Conversation

@OverloadedTech

Copy link
Copy Markdown

A Value regex that ends in an escaped backslash is rejected, even though it's a valid regex:

Value Drive ([A-Z]:\\)

fails with Value '([A-Z]:\\)' must be contained within a '()' pair.

The check added in #99 rejects the regex if the character before the last ) is a backslash, to catch an escaped \). But in \\) the backslash is itself escaped and the ) is a normal one. Now it counts the backslashes before the final ) and only rejects an odd number, so (boo)hoo\) and (boo)hoo\\\) are still errors.

Added cases to testFSMValue, the new one fails without the change. pytest tests: 113 passed. Also ran a small template with that Value through the textfsm command, it parses C:\ / D:\ lines now.

The check for an escaped closing ')' only looked at the character
before it, so a regex ending in an escaped backslash like ([A-Z]:\\)
was rejected as not being inside a '()' pair. Count the backslashes
instead and only reject an odd number.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant