Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions tests/textfsm_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,15 @@ def testFSMValue(self):
textfsm.TextFSMTemplateError, v.Parse, r'Value beer (boo)hoo\)'
)

# An escaped backslash before the closing parenthesis is allowed.
v = textfsm.TextFSMValue(options_class=textfsm.TextFSMOptions)
v.Parse(r'Value beer (boo\\)')
self.assertEqual(v.regex, r'(boo\\)')
self.assertEqual(v.template, r'(?P<beer>boo\\)')
self.assertRaises(
textfsm.TextFSMTemplateError, v.Parse, r'Value beer (boo)hoo\\\)'
)

# A missing regex is a template error, not an IndexError.
v = textfsm.TextFSMValue(options_class=textfsm.TextFSMOptions)
self.assertRaises(
Expand Down
4 changes: 3 additions & 1 deletion textfsm/parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -305,11 +305,13 @@ def Parse(self, value):
"Invalid Value name '%s' or name too long." % self.name
)

# An odd number of backslashes before the final ')' means it is escaped.
backslashes = len(self.regex[:-1]) - len(self.regex[:-1].rstrip('\\'))
if (
not self.regex
or self.regex[0] != '('
or self.regex[-1] != ')'
or self.regex[-2] == '\\'
or backslashes % 2
):
raise TextFSMTemplateError(
"Value '%s' must be contained within a '()' pair." % self.regex
Expand Down
Loading