Repository navigation
[util] Guard Taints.findTaint against null node spec/taints - #4958
Draft
yue9944882 wants to merge 1 commit into
Draft
yue9944882 wants to merge 1 commit into
yue9944882 wants to merge 1 commit into
Conversation
findTaint iterated node.getSpec().getTaints() with no null check, throwing a NullPointerException for a node that has no spec (or whose taints list is null) instead of reporting that no matching taint exists. The sibling removeTaint methods already guard a null spec, so this was an inconsistent null-safety gap. Return null when the spec or taints list is absent, and add a focused unit test covering a node without a spec.
kubernetes-prow
Bot
added
the
do-not-merge/work-in-progress
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yue9944882 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Taints.findTaint(V1Node, String, Effect)iteratesnode.getSpec().getTaints()with no null check. For a node that has no spec (e.g. a freshly builtV1Node), or whose taints list is explicitly null, this throws aNullPointerExceptioninstead of reporting that no matching taint exists.This is inconsistent with the sibling
removeTaintmethods in the same class, which already guard a null spec and return gracefully — sofindTaintwas an oversight in null handling, not intended behavior.Fix
Return
nullwhen the node has no spec or no taints list, before iterating. Minimal 3-line guard; no API/signature changes, no behavior change for nodes that do have taints.Verification
./mvnw -pl util -am -Dtest=TaintsTest -Dsurefire.failIfNoSpecifiedTests=false testfindTaintWithoutSpecReturnsNull.V1Node.getSpec()is null).Tests run: 4, Failures: 0, Errors: 0— BUILD SUCCESS.