Skip to content

[util] Guard Taints.findTaint against null node spec/taints #4958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendandburns merged 1 commit into from
Oct 23, 2026
+11 −0
Merged

[util] Guard Taints.findTaint against null node spec/taints #4958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions util/src/main/java/io/kubernetes/client/util/taints/Taints.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ public String toString() {
}

public static V1Taint findTaint(V1Node node, String key, Effect effect) {
if (node.getSpec() == null || node.getSpec().getTaints() == null) {
return null;
}
for (V1Taint taint : node.getSpec().getTaints()) {
if (taint.getKey().equals(key) && taint.getEffect().equals(effect.toString())) {
return taint;
Expand Down
8 changes: 8 additions & 0 deletions util/src/test/java/io/kubernetes/client/util/taints/TaintsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,12 @@ void noExecuteTaints() {
assertThat(Taints.findTaint(node, "key1", Taints.Effect.NO_EXECUTE).getEffect())
.isEqualTo(effect);
}

@Test
void findTaintWithoutSpecReturnsNull() {
// A node without a spec (or without a taints list) must not NPE; it simply has no taints,
// consistent with the null-spec handling in removeTaint.
V1Node node = new V1Node();
assertThat(Taints.findTaint(node, "key1", Taints.Effect.NO_SCHEDULE)).isNull();
}
}
Loading