Repository navigation
feat!: Make EvaluationDetail.is_default_value a property - #555
Merged
Merged
Conversation
EvaluationDetail.is_default_value is now a property, like the other getters on EvaluationDetail. Callers must drop the parentheses and write detail.is_default_value.
kinyoklion
approved these changes
Nov 3, 2026
kinyoklion
left a comment
kinyoklion
left a comment
Member
There was a problem hiding this comment.
We should probably change the assertions to not use bare truthiness, because methods would also have passed a truthiness test.
A bound method is truthy, so a bare truthiness assertion also passes if is_default_value is a method. Comparing with True confirms that it is a property that returns a bool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EvaluationDetail.is_default_valueis now a property, like the other getters onEvaluationDetail. Callers must drop the parentheses and writedetail.is_default_value.Note
Overview
Breaking change:
EvaluationDetail.is_default_valueis now a property (likevalue,variation_index, andreason), not a method. Call sites must usedetail.is_default_valueinstead ofdetail.is_default_value().The sync and async clients’ default-value handling and the affected tests were updated to match. Behavior is unchanged—it still means the evaluation returned the caller’s default (
variation_index is None).Reviewed by Cursor Bugbot for commit 7f5d936. Bugbot is set up for automated code reviews on this repo. Configure here.