feat!: Make EvaluationDetail.is_default_value a property

ldclient/async_client.py

@@ -532,7 +532,7 @@ async def _evaluate_internal(self, key: str, context: Context, default: Any, eve
                 for event in result.events or []:
                     self._send_event(event)
                 detail = result.detail
-                if detail.is_default_value():
+                if detail.is_default_value:
                     detail = EvaluationDetail(default, None, detail.reason)
                 self._send_event(event_factory.new_eval_event(flag, context, detail, default))
                 return detail, flag

ldclient/client.py

@@ -504,7 +504,7 @@ def _evaluate_internal(self, key: str, context: Context, default: Any, event_fac
                 for event in result.events or []:
                     self._send_event(event)
                 detail = result.detail
-                if detail.is_default_value():
+                if detail.is_default_value:
                     detail = EvaluationDetail(default, None, detail.reason)
                 self._send_event(event_factory.new_eval_event(flag, context, detail, default))
                 return detail, flag

ldclient/evaluation.py

@@ -64,9 +64,10 @@ def reason(self) -> dict:
         """
         return self.__reason
 
+    @property
     def is_default_value(self) -> bool:
-        """Returns True if the flag evaluated to the default value rather than one of its
-        variations.
+        """This property is True when the flag evaluation gives the default value and not one of
+        the flag variations.
         """
         return self.__variation_index is None
 

ldclient/testing/impl/datasystem/test_fdv2_persistence.py

@@ -834,7 +834,7 @@ def test_variation_does_not_throw_when_persistent_store_errors_during_warm_start
         detail = client.variation_detail("flag-key", context, default="default-value")
         assert detail.value == "default-value"
         assert detail.reason == {"kind": "ERROR", "errorKind": "CLIENT_NOT_READY"}
-        assert detail.is_default_value() is True
+        assert detail.is_default_value is True
 
         assert client.all_flags_state(context).valid is False
     finally:

ldclient/testing/test_ldclient_evaluation.py

@@ -128,7 +128,7 @@ def test_variation_detail_for_flag_that_evaluates_to_none():
     expected = EvaluationDetail('default', None, {'kind': 'OFF'})
     actual = client.variation_detail('feature.key', user, default='default')
     assert expected == actual
-    assert actual.is_default_value() is True
+    assert actual.is_default_value is True
 
 
 def test_variation_when_feature_store_throws_error(caplog):
@@ -145,7 +145,7 @@ def test_variation_detail_when_feature_store_throws_error(caplog):
     expected = EvaluationDetail('default', None, {'kind': 'ERROR', 'errorKind': 'EXCEPTION'})
     actual = client.variation_detail('feature.key', Context.from_dict({"key": "user", "kind": "user"}), default='default')
     assert expected == actual
-    assert actual.is_default_value() is True
+    assert actual.is_default_value is True
     errlog = get_log_lines(caplog, 'ERROR')
     assert errlog == ['Unexpected error while retrieving feature flag "feature.key": NotImplementedError()']