Skip to content

decisions: PLATFORM-PIN moves to platform-sw 131e500 (2.0 base) - #74

Merged
BotshareAI merged 3 commits into
mainfrom
decisions/platform-pin-131e500
Nov 1, 2026
Merged

BotshareAI merged 3 commits into
mainfrom
decisions/platform-pin-131e500

Conversation

@BotshareAI

@BotshareAI BotshareAI commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Updates the PLATFORM-PIN entry in decisions.yaml (P-03 rev20.1 item 25, decision D7): the combined robot model in openamr-upperbody-sw is tested against platform-sw 131e500fc4e5afc9f648cbd7dbf5b416280761fb (the 2.0 base), dated 2026-10-30. The dfd44a5 pin of 20 Oct 2026 moves to supersedes. Source: "P-03 rev20.1 item 25 D7; validated by openamr-upperbody-sw PR #21 (A6 793 executed / 0 failed, A7 246 executed / 0 failed at a0f7dd6)". P-03-rev20.1 is added under sources (the validator requires every cited document to be listed). Check patterns unchanged. Scope: decisions.yaml (PLATFORM-PIN) and the PLATFORM-PIN row of STATE.md.

Updated from main at 1678735 (P-03 rev20.2 in force); only the PLATFORM-PIN entry differs from main. openamr-upperbody-sw #21 is merged.

Work package

Contract/decision update for P-03 rev20.1 item 25 D7; consumer close-out is openAMRobot/openamr-upperbody-sw#10 (A6 + A7, roadmap OA-12).

Integration Gate

Tests

No checker or pattern change, so no new test. The register is exercised by the checker unit tests in rollout/verify.sh: before adding P-03-rev20.1 to sources, the same run failed (validator: "PLATFORM-PIN: source document 'P-03-rev20.1' not listed under sources"); with it, 278 of 278 executed, 0 skipped, PASS. main 71c439e: 278 of 278, PASS.

Evidence

Base SHA: 1678735 (main, P-03 rev20.2 in force)
Head SHA: acd864b (7070e32 merge of origin/main into 30b46b2, plus the STATE.md PLATFORM-PIN row; git diff origin/main...HEAD -- decisions.yaml shows only the PLATFORM-PIN entry)

Run locally on acd864b:

bash rollout/verify.sh
  Tests executed: 289 of 289 (skipped 0); PASS: all detected verification stages
python3 tools/check_decisions.py --decisions decisions.yaml --maintainers maintainers.yaml --validate-only
  decisions: 46 loaded, 41 recorded and scanned, 2 open, 3 superseded (citations scanned); exit 0
python3 tools/check_agent_rules.py --canonical agent-rules/SHARED_RULES.md --file AGENTS.md
  PASS AGENTS.md (v2)
python3 tools/check_pr_evidence.py --event <this description, head acd864b> --changed-files <decisions.yaml, STATE.md> --maintainers maintainers.yaml --root .
  PR evidence check: PASS; exit 0

Checks on acd864b (https://github.com/openAMRobot/.github/actions/runs/41343880048): DCO success; quality/test success; repository-quality / repository-quality success; ros-verifier-smoke success; repository-quality / quality/test skipped by the workflow.

Dependencies

None.

Safety impact

None.

STATE.md

Updated in acd864b: the PLATFORM-PIN row now records the pin 131e500fc4e5afc9f648cbd7dbf5b416280761fb (2.0 base, P-03 rev20.1 item 25 D7), validated by openamr-upperbody-sw #21 and merged with this PR; the stale "rebase after whichever merges first" next step is removed. No other line of STATE.md changed.

Not verified

  • Software-lead re-approval is pending: the earlier approval of the D7 record was dismissed when 7070e32 was pushed.

AI disclosure

Claude Code, at Alex Reznichenko's request, produced the register edit, the merge of main (7070e32), the STATE.md update (acd864b), the commits and this description. The owner (Alex Reznichenko) adopted this register change on 1 Nov 2026.

Contribution terms

  • Every commit is signed off under the DCO.
  • I am covered by an accepted Contributor Agreement.
  • Third-party material is identified with source and licence.
  • No confidential, personal, credential or export-controlled information is included.
  • No partner, customer or private person is named; the application is Use_Case_1.

Generated by Claude Code

P-03 rev20.1 item 25 D7: the combined robot model in openamr-upperbody-sw
is now tested against platform-sw 131e500fc4e5afc9f648cbd7dbf5b416280761fb.
Validated by openamr-upperbody-sw PR #21 (A6 793 executed / 0 failed,
A7 246 executed / 0 failed at a0f7dd6). The dfd44a5 pin of 20 Oct 2026
moves to supersedes; P-03-rev20.1 is added to sources.

bash rollout/verify.sh: 278 of 278 executed, PASS.
check_decisions.py --validate-only: 39 loaded, valid.

Assisted-by: Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DZnPENZHgKq9tLAj9DLAnR
Signed-off-by: Alex Reznichenko <info@botshare.ai>

@panthera-momagdii panthera-momagdii left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Focused integration/provenance review at head 30b46b2d90ba1c7646c841f100e7eb6080b27785, changing only decisions.yaml. I inspected the exact register diff, shared AGENTS/decision rules, the linked upperbody #21 validation and the current parallel governance #73 diff. The register checker and Repository quality results for #74 are green, but this is not an approval.

[P2] Coordinate with #73 before making the new PLATFORM-PIN authoritative. Both PRs branch from main at 71c439e and both add sources.P-03-rev20.1 at the same insertion point, with different source-title/provenance text. #73 also changes in_force.source from rev19.6 to rev20.1, and currently has an outstanding changes-requested review concerning overly broad contradiction-checker exceptions. #74 does not mention #73 in its Integration Gate and, merged by itself, would cite rev20.1 for the pin while in_force still says rev19.6. Please put #73 first in the merge order; after its checker and owner review are resolved, bring that exact reviewed head into this branch with a normal merge commit (no force-push), keep one consistent P-03-rev20.1 source definition, retain the in-force date/source and this PR's PLATFORM-PIN history, and rerun bash rollout/verify.sh and check_decisions.py --validate-only on the combined tree. If the platform lead prefers a single register PR, consolidate there instead and close the redundant one only by owner action.

Primary decision still requires a human source check: the P-03 rev20.1 item 25 D7 document is not in the repository. #21's tested platform SHA 131e500 is independently evidenced, but successful static/mock and simulation runs are not approval of the source wording or hardware. Keep the register PR draft until Alex/software lead confirms the exact decision and consumer/owner handoff. No repository code, register values or settings were changed by this review. Not run locally: the full register verifier, A6/A7, hardware. AI-assisted focused review.

@panthera-momagdii panthera-momagdii left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved the PLATFORM-PIN decision update (D7) in scope: use platform-sw 131e500fc4e5afc9f648cbd7dbf5b416280761fb for the recorded 30 October 2.0 combined-model validation, preserve the older dfd44a5 value under supersedes, and require exact pinned A6/A7 evidence when subsequently moving the pin. PR #21 supplied the claimed 131e500 validation. The original overlap with #73 was addressed on main; I inspected the current decisions.yaml and PR patch.

Integration condition, not a new decision: this PR's branch still predates main's approved P-03 rev20.2 register and currently compares as diverged/non-mergeable. Before merging, reconcile decisions.yaml against current main, retain in_force: P-03-rev20.2, BOM 7.14 and the canonical existing sources.P-03-rev20.1 title/metadata, and apply only the scoped PLATFORM-PIN entry. Do not replace the full register with this historical branch snapshot, duplicate the source key or revert unrelated decisions. Re-run register/quality checks on the reconciled head and obtain re-review if GitHub dismisses this approval. The eventual 2.0 production/platform-main pin after #105 is a separate coordinated change requiring A6/A7. This approval is for the D7 record, not for merging an unresolved conflict or authorizing unrelated engineering changes.

…tform-pin-131e500

sources: kept main's block (P-03-rev20.2, BOM-Issue-7.14, P-03-rev20.1);
dropped the branch's duplicate P-03-rev20.1 entry. PLATFORM-PIN keeps the
branch change (131e500, 2026-10-30, supersedes dfd44a5, P-03-rev20.1 item
25 D7). in_force stays as on main.

Checks: bash rollout/verify.sh PASS (289 of 289, skipped 0);
check_decisions.py --validate-only PASS (46 loaded).

Assisted-by: Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DZnPEPyqqN1uREf7LZs7MK
Signed-off-by: Alex Reznichenko <info@botshare.ai>

@panthera-momagdii panthera-momagdii left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Focused re-approval of the PLATFORM-PIN D7 register update at exact head 7070e323cd23611c7ac4497e8fc7455cc0d3c2bc after reconciliation with current main. Compared the prior reviewed branch and current one-file PR patch, read the full relevant decisions.yaml source and PLATFORM-PIN entry alongside current main, previous reviews, owner decision and shared AGENTS.md rules. The historical record now retains P-03 rev20.2 as in force, keeps the canonical rev20.1 provenance and BOM 7.14 references, moves only the recorded D7 platform pin to 131e500fc4e5afc9f648cbd7dbf5b416280761fb, and preserves the prior dfd44a5 under supersedes. The earlier integration conflict is resolved; the current PR is mergeable, still draft. Exact-head hosted Repository quality quality/test, Validate decisions.yaml, Decisions of record and shared-rules checks passed (run 41343036728); skipped optional reusable quality/test is not counted as a pass. APPROVE only this historical decision-register update. Keep draft/owner handoff and all normal merge gates intact. A future move to platform-sw main after #105 and combined-model #26/#27 adoption requires a separate coordinated change and full exact-pin A6/A7 rerun; this review does not approve physical geometry, robot safety or a later platform pin. NOT RUN locally: full rollout/verify.sh, Python decision checker, A6/A7, ROS/Gazebo and hardware. No source, settings, workflow or merge actions.

@BotshareAI
BotshareAI marked this pull request as ready for review November 1, 2026 19:48
@BotshareAI
BotshareAI requested a review from wikki26 as a code owner November 1, 2026 19:48
The pin is platform-sw 131e500fc4e5afc9f648cbd7dbf5b416280761fb (2.0 base,
P-03 rev20.1 item 25 D7), validated by openamr-upperbody-sw #21. Drops the
stale "rebase after whichever merges first" next step. No other row changed.

Assisted-by: Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DZnPEPyqqN1uREf7LZs7MK
Signed-off-by: Alex Reznichenko <info@botshare.ai>

@panthera-momagdii panthera-momagdii left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approval at exact head acd864b4734dc9fbc36c937b17c74cd22bf56dce after the main/rev20.2 reconciliation. I checked the current PR patch: decisions.yaml changes only the recorded PLATFORM-PIN decision from historical dfd44a5 to the 30 October validated 2.0 base 131e500 (retaining superseded history); STATE.md also updates the PR tracking row. The current P-03 rev20.2 register, source metadata and unrelated decisions remain intact. Exact-head Repository quality including quality/test and ros-verifier-smoke succeeded; CLA passed. The PR's STATE.md row refers to the pin as 'merged with this PR', which is prospective until merge and should not be interpreted as already merged. Approval covers the historical D7 pin decision only; later adoption of post-#105 platform main still requires a coordinated pin update and full A6/A7 rerun. No source edits, merge, safety authorization or local ROS run in this review.

@BotshareAI
BotshareAI merged commit a9e229e into main Nov 1, 2026
6 checks passed
@BotshareAI
BotshareAI deleted the decisions/platform-pin-131e500 branch November 1, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants