Repository navigation
Drop idle connections and resend reset requests; selection-colour ticks; ticker picker wording - #52
Merged
Merged
Conversation
A toggle that is on (a ticked ticker in the .price picker) is drawn as the button shown now is: Telegram's primary (blue) and Discord's style 1 (blurple), in place of success and style 3 (green). Slack has one selection colour, primary, which is green, and keeps it. A toggle that is off stays red. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
CLAUDE.md and a test docstring said "tickers menu" for what the rest of the code and docs call the ticker picker. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
…again The shared session reuses connections, and a server closes one left idle: the next request on it failed with a reset (errno 104), and a chart that met it went as text. - net.fresh: a host's connections unused for 20 seconds are dropped before the next request to it, so a stale one is never reused. - Transport.sent sends a request the server reset once more, whole (a chart as a chart), and only then gives up as before; net.was_reset reads the reset through requests' and urllib3's wrapping. At worst a message that did arrive comes twice. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three follow-ups to #51.
net.freshdrops a host's connections that have been unused for 20 seconds before the next request to that host.Transport.sentsends a request the server reset once more, whole: a chart is sent again as a chart, not as its heading plus text. If the first copy did arrive despite the reset, it comes twice.primary), Discord blurple (style 1). Slack keeps its single selection style,primary, which is green. A toggle that is off stays red.Testing
.venv/bin/python -m unittest discover -s tests -b: 640 tests pass, including new ones for the idle drop and the resend.util/record_outputs.py: 293 steps identical.Generated by Claude Code