Skip to content

fix(resume): classify the planfile failed status as blocked pending work (ticket-118) - #141

Merged
ifuri-validator-agent[bot] merged 1 commit into
mainfrom
ticket/118-failed-status-blocked
Oct 15, 2026
Merged

ifuri-validator-agent[bot] merged 1 commit into
mainfrom
ticket/118-failed-status-blocked

Conversation

@tom-sapletta-com

Copy link
Copy Markdown
Contributor

Ticket: ticket-118

failed is a first-class planfile TicketStatus (execution attempts exhausted), but monag resume had it in neither OPEN nor CLOSED, so summarize_tickets counted it in unknown_statuses. The fleet admission gate requires unknown_statuses == 0, so willman project intake was denied with ambiguous_queue_state for every repository holding one failed ticket — 352 local repositories, including subactor/reflex (PLF-012) and subactor/subllm. Found by a willman canary campaign on reflex (job 45547e85, intake_denied).

Change: STALLED = {'blocked', 'failed'} is a subset of OPEN; blocked is counted from it. A failed ticket stays visible as remaining work needing triage and is never ready work.

Evidence: new test_planfile_failed_status_is_blocked_remaining_work; tests/test_resume.py 27 passed; full suite 520 passed, 1 skipped (test_panel::test_report_endpoints timed out once under load, passes alone on main and branch); governance-check GOV-PASS. Scanning reflex with the fix: unknown 0, remaining 4, blocked 3.

Rollout (separate): the willman controller pins a monag release.

…ork (ticket-118)

failed is a planfile TicketStatus but was neither OPEN nor CLOSED, so it
counted as an unknown status and fleet admission denied willman intake with
ambiguous_queue_state for every repository holding one failed ticket.

Ticket: ticket-118

@ifuri-validator-agent ifuri-validator-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validator approval after policy checks for exact head 74f408d07110faef1248e288ec625e218a75c224.

Ticket: ticket-118
Correlation ID: local-semcod-monag-pr-141-ticket-118
Model: openai/cursor-auto
Reviewed diff chunks: 1
Advisory LLM verdict: REQUEST_CHANGES
Advisory summary: Reviewed all 1 diff chunk(s). The runtime change correctly classifies failed as stalled open work, counts it as blocked, and adds focused regression coverage. All supplied required checks pass.
Advisory findings: project/TICKETS.md adds an index entry for ticket-117 but does not add the new ticket-118 entry introduced by this change, leaving the ticket registry inconsistent with the new ticket files.
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.

Actual PR impact radar

Exact range: 18649ba045f6277fac3ec42e762243f30f6b3b1b...74f408d07110faef1248e288ec625e218a75c224
Change digest: a33fe4cf7d985560c0c4ab370db8dfe85988301f5d1536b1b044dfe966aa9628
Score: 60/100 (L), estimated 65 min, split recommended: true
Affected services/components: repository-wide/unclassified

Machine-readable radar JSONL and SVG
{"actual_change":{"additions":140,"base_sha":"18649ba045f6277fac3ec42e762243f30f6b3b1b","binary_files":0,"categories":{"code":1,"configuration":1,"docs":2,"tests":1},"change_digest":"a33fe4cf7d985560c0c4ab370db8dfe85988301f5d1536b1b044dfe966aa9628","comparison":"18649ba045f6277fac3ec42e762243f30f6b3b1b...74f408d07110faef1248e288ec625e218a75c224","deletions":2,"file_count":5,"files":["project/TICKETS.md","project/ticket-118/README.md","project/ticket-118/intent.json","src/monag/resume.py","tests/test_resume.py"],"head_sha":"74f408d07110faef1248e288ec625e218a75c224","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":4,"delivery":3,"scope":3,"uncertainty":3,"validation":2},"complexity":"L","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":65,"within_budget":false},"impact":{"components":["project","src/monag","subactor","tests"],"files":["project/TICKETS.md","project/ticket-118/README.md","project/ticket-118/intent.json","src/monag/resume.py","subactor/reflex","subactor/subllm","tests/test_resume.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":60,"split":{"parts":[{"estimated_minutes":14,"name":"Implement project","scope":["project"]},{"estimated_minutes":14,"name":"Implement src/monag","scope":["src/monag"]},{"estimated_minutes":14,"name":"Implement subactor","scope":["subactor"]},{"estimated_minutes":14,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-118"}
<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-118: fix(resume): classify the planfile failed status as blocked pending work (ticket-118)</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,38 97,53 79,85 54,78 39,56" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">L · 65m</text></svg>
Merge will be attempted after this approval when explicitly authorized. ## Decision record (recomputable)
DECISION D-118-2829
TICKET ticket-118
HEAD_SHA 74f408d07110faef1248e288ec625e218a75c224
CORRELATION_ID local-semcod-monag-pr-141-ticket-118
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["governance / enforce=PASS","governance / remote lifecycle=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["onedev/local-verify","governance / remote lifecycle","governance / enforce"]
INPUT required_checks_source = "protected registry (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/monag","pull_request":141,"head_sha":"74f408d07110faef1248e288ec625e218a75c224","base_sha":"18649ba045f6277fac3ec42e762243f30f6b3b1b","diff_sha256":"dd4a7044d99c68e8a93ddd462108a0d2501c82fe639e2c60301b4ded704d0a55"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["project/TICKETS.md","project/ticket-118/README.md","project/ticket-118/intent.json","src/monag/resume.py","tests/test_resume.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"18649ba045f6277fac3ec42e762243f30f6b3b1b","head_sha":"74f408d07110faef1248e288ec625e218a75c224","change_digest":"a33fe4cf7d985560c0c4ab370db8dfe85988301f5d1536b1b044dfe966aa9628","score":60,"complexity":"L","estimated_minutes":65,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "REQUEST_CHANGES" MODEL "openai/cursor-auto"
ASSERT VERDICT_AUTHORITY != "ADVISORY"

@ifuri-validator-agent
ifuri-validator-agent Bot merged commit f8bff8c into main Oct 15, 2026
3 checks passed
@ifuri-validator-agent
ifuri-validator-agent Bot deleted the ticket/118-failed-status-blocked branch October 15, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant