Repository navigation
Run Physical's tests on macOS and on Linux on Arm in CI - #75
Merged
Merged
Conversation
…s Physical's tests On macOS the temp folder is under /var, a link to /private/var, so a chain of exactly the link limit made there passed one link more than the test counted, and the kernel would refuse it too: the test now makes its chains in the folder's physical path. AGENTS.md, REVIEW.md, CONTRIBUTING.md and release.yml's comments name the new jobs. Refs #73
…es on The link-chain test now also reads through the kernel: a chain of exactly the limit opens and one link more fails, which the macOS job checks against Darwin's 32 and Linux's against 40. release.yml and AGENTS.md name the Native AOT job among those a release needs green; Arm64 is said throughout, and the paragraphs the change touched are rewrapped. Refs #73
serionist
force-pushed
the
73-ci-macos-arm
branch
from
October 13, 2026 09:37
8c799c4 to
67020c1
Compare
serionist
marked this pull request as ready for review
October 13, 2026 09:41
serionist
added a commit
that referenced
this pull request
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Step 2 of the 2027.1.1 plan (
docs/plans/2026-10-13-2027-1-1.md, onmainsince #74; this PR adds step 2's progress log entry). Physical's tests ran in CI on Linux x64 and Windows only, and have never run on macOS. #70 will make Physical delete folders through the C library with flags whose values differ by system and architecture, so its tests should run on each before it lands. Two jobs, one matrix:macos-latest(Arm64) andubuntu-24.04-arm, set up as the other jobs (locked restore,persist-credentials: false, actions pinned by SHA).What the first runs found: Arm64 passed as it was. macOS failed one test,
PhysicalPathOf_StopsWhereTheKernelDoes: the temp folder there is under/var, a link to/private/var, so a chain of exactly the link limit made in it passed one link more than the test counted, and Darwin would refuse it too. The chains are now made in the folder's physical path, and the test also reads through them, so the kernel itself confirms the limit (32 on macOS, 40 on Linux): exactly the limit opens, one link more fails withIOException.Docs:
AGENTS.md(the CI and Release bullets, the Physical tests line),REVIEW.md(Build and tests),CONTRIBUTING.md, andrelease.yml's comments now name the Physical jobs, and the Native AOT job, which they had left out, among what a release needs green fromci.yml.Plan
docs/plans/2026-10-13-2027-1-1.md, step 2 (P9: the jobs land before #70 so whatever they find is fixed first).Tested by
Review
review-code, standard tier (Opus), two rounds: clean.
IOExceptionfor ELOOP on Linux and macOS; nothing new.Physical (macOS)andPhysical (Linux, Arm64)become required checks onmain, so a red one blocks a merge, not only a release.One-way doors
None. The new jobs are part of
ci.yml, whose successrelease.ymlrequires on a tagged commit, so they gate releases as the Windows job does.Closes #73