Repository navigation
feat(sensors): DPI-aware column density, bordered sections - #2
mirkobrombin merged 2 commits into
Conversation
2ef5167 to
ebed25c
Compare
|
@mirkobrombin bumping this one - restores the bordered-section styling and DPI-aware column density that got dropped when sensors moved from panel.vala into this plugin. Depends on libsingularity#15 for the CSS class. |
|
The scale factor logic is backwards: popovers are laid out in logical pixels, so multiplying by scale gives HiDPI screens more columns on less space (1280 logical @2x gets 3 columns, a ~1056px popover). Keep the logical-only calculation. Also move |
93a5bd5 to
05d6471
Compare
|
@mirkobrombin both points from your review are fixed in 05d6471 (rebased on main d255d47):
Built on main with shell#30 and desktop#262 on forky arm64: ninja 379/379 targets, meson test 23/23 pass. Please take another look. |
05d6471 to
8553cb7
Compare
The detail popover used a fixed one or two columns. Count columns from the logical monitor width (up to three) and outline each resource section with a plugin-owned style. Assisted-by: Claude Code:claude-sonnet-5 Assisted-by: Codex:gpt-5.6-sol AI-Scope: Wrote the multi-column layout and the section outline style.
8553cb7 to
7e0584e
Compare
|
The new math dropped 1280 logical px to a single column, which was two before. I put fixed thresholds back: two columns from 1280, three from 1920. Also rebased and removed the added comment. Merging. |
2 participants
Makes the sensors detail popover responsive using logical monitor pixels only and keeps the balanced multi-column layout.
The sensors-resource-section rule now lives in the plugin own compact_rows_provider, so the plugin no longer depends on libsingularity for plugin-specific styling.
Verified by building sensors/libsensors.so with Meson and Ninja in a Debian trixie container against the current libsingularity fallback. The 1280 logical-pixel acceptance calculation produces one 340-pixel column at either scale 1 or scale 2.
AI assistance: disclosed