Repository navigation
[Simulation] add warnings if mapping in/out is out of the context - #6370
Merged
Merged
Conversation
alxbilger
added
pr: status to review
alxbilger
changed the title
hugtalbot
added
pr: status ready
hugtalbot
approved these changes
Oct 15, 2026
hugtalbot
left a comment
hugtalbot
left a comment
Contributor
There was a problem hiding this comment.
Good for me, shall we merge @alxbilger ?
alxbilger
added
pr: status to review
Contributor
Author
|
@hugtalbot Not yet, I'll plan to trigger this warning only once otherwise it triggers zillions of times by time step, and I'll extend it to more components. |
bakpaul
approved these changes
Oct 16, 2026
fredroy
added
pr: status wip
alxbilger
added
pr: status to review
alxbilger
force-pushed
the
warningmappinggraph
branch
from
October 29, 2026 15:46
40cf1c5 to
b554f3a
Compare
hugtalbot
added
pr: status ready
fredroy
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trigger warning if the input or the output of a mapping is out of the context of the mapping graph, i.e. not a child of the root node of the mapping graph.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if