Skip to content

[Simulation] add warnings if mapping in/out is out of the context #6370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fredroy merged 3 commits into from
Nov 5, 2026
Merged

[Simulation] add warnings if mapping in/out is out of the context #6370

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d567ec3
add warnings
alxbilger Oct 9, 2026
b554f3a
trigger warning only once
alxbilger Oct 29, 2026
df3e38f
fix second operand not evaluated in condition
alxbilger Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion Sofa/framework/Simulation/Core/src/sofa/simulation/MappingGraph.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ void MappingGraph::build(const InputLists& input)

// 1. Create one wrapper node per object; index state nodes by raw ptr.
std::vector<MappingGraphNode<sofa::core::behavior::BaseMechanicalState>*> mechanicalStateNodes;
for (auto& s : input.mechanicalStates)
for (auto* s : input.mechanicalStates)
{
auto node = makeMappingGraphNode<sofa::core::behavior::BaseMechanicalState>(s);
mechanicalStateNodes.push_back(node.get());
Expand Down Expand Up @@ -333,6 +333,16 @@ void MappingGraph::build(const InputLists& input)
{
addEdge(sn, mappingNode);
}
else
{
thread_local sofa::helper::logging::OnceTracker sofaMsgOnceTracker;
const bool firstTimeMapping = sofaMsgOnceTracker.firstTimeFor(static_cast<const void*>(input.mappings[i]));
const bool firstTimeState = sofaMsgOnceTracker.firstTimeFor(static_cast<const void*>(s));
if (firstTimeMapping || firstTimeState)
{
msg_warning(input.mappings[i]) << "Mapping input '" << s->getPathName() << "' is not contained in the mapping graph context. It will not be considered when traversing the graph, neither the components relying on it.";
}
}
}
}

Expand All @@ -342,6 +352,16 @@ void MappingGraph::build(const InputLists& input)
{
addEdge(mappingNode, sn);
}
else
{
thread_local sofa::helper::logging::OnceTracker sofaMsgOnceTracker;
const bool firstTimeMapping = sofaMsgOnceTracker.firstTimeFor(static_cast<const void*>(input.mappings[i]));
const bool firstTimeState = sofaMsgOnceTracker.firstTimeFor(static_cast<const void*>(s));
if (firstTimeMapping || firstTimeState)
{
msg_warning(input.mappings[i]) << "Mapping output '" << s->getPathName() << "' is not contained in the mapping graph context. It will not be considered when traversing the graph, neither the components relying on it.";
}
}
}
}

Expand Down
Loading