Skip to content

Redirect /containers to the multi-container Machines guide, and fix Vale on deletions - #2594

Merged
kcmartin merged 2 commits into
mainfrom
containers-redirect
Oct 22, 2026
Merged

kcmartin merged 2 commits into
mainfrom
containers-redirect

Conversation

@kcmartin

@kcmartin kcmartin commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Two things, the second one found by the first.

1. /containers was a dead stub with a sidebar entry. A 6 line page reading "Moved! https://fly.io/docs/", listed under Getting Started right after guides, so the nav advertised a Containers page that bounced readers to the docs root. This removes the nav entry, deletes the stub, and redirects /containers to the multi-container Machines guide, the only container content in the docs. Verified on the preview: /containers now lands on /machines/guides-examples/multi-container-machines.

Found while measuring what's left on https://github.com/superfly/docs-tracking/issues/352. It was one of 26 nav pages with no description:, but it needed removing rather than describing.

Notes on the target, since it's a judgment call rather than a restoration:

  • The stub arrived already a stub in the 17 September import, so the "Moved!" predates Mintlify and there's no history to recover the original content from.
  • Nothing in the repo links to /containers. The only hit is the stub's own source_url.
  • I found no /docs/containers/ row in the 3 month organic export, in the page, entry or exit files. That export is from early August, so pre-migration.
  • The guide is about sidecars with Pilot and the containers array, so it isn't the answer to "how do I deploy a Docker container on Fly" if that's what the old page covered. Sending it to / instead would preserve today's behavior exactly.

2. Deleting a page broke the Vale check, and this was the first PR to do it. That's a regression from #2591:

##[error]Error: { "Text": "argument 'containers.mdx' does not exist", "Code": "E100" }

all_changed_and_modified_files is ACMRDTUX and includes deleted paths, and Vale exits non-zero on a path that isn't there. fail_on_error: false doesn't cover it, because it's an invocation error rather than a lint finding. Before #2591 the broken file list made the action lint the whole repo, so this never surfaced.

all_changed_files is ACMR, which excludes deletions. Green on the re-run, with the deleted path gone from the list: https://github.com/superfly/docs/actions/runs/39822989953

The CI fix is in this PR because this is the only PR that reproduces the failure. Same fix for sprites-docs is superfly/sprites-docs#276. Happy to split it out if you'd rather keep the content change clean.

@mintlify

mintlify Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
fly-io 🟢 Ready View Preview Oct 22, 2026, 5:27 PM

💡 Tip: Enable Automations to automatically generate PRs for you.

@kcmartin kcmartin changed the title Redirect /containers to the multi-container Machines guide Redirect /containers to the multi-container Machines guide, and fix Vale on deletions Oct 22, 2026
@kcmartin
kcmartin merged commit 514e4ab into main Oct 22, 2026
2 checks passed
@kcmartin
kcmartin deleted the containers-redirect branch October 22, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant