Repository navigation
Redirect /containers to the multi-container Machines guide, and fix Vale on deletions - #2594
Merged
Merged
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things, the second one found by the first.
1.
/containerswas a dead stub with a sidebar entry. A 6 line page reading "Moved! https://fly.io/docs/", listed under Getting Started right afterguides, so the nav advertised a Containers page that bounced readers to the docs root. This removes the nav entry, deletes the stub, and redirects/containersto the multi-container Machines guide, the only container content in the docs. Verified on the preview:/containersnow lands on/machines/guides-examples/multi-container-machines.Found while measuring what's left on https://github.com/superfly/docs-tracking/issues/352. It was one of 26 nav pages with no
description:, but it needed removing rather than describing.Notes on the target, since it's a judgment call rather than a restoration:
/containers. The only hit is the stub's ownsource_url./docs/containers/row in the 3 month organic export, in the page, entry or exit files. That export is from early August, so pre-migration.containersarray, so it isn't the answer to "how do I deploy a Docker container on Fly" if that's what the old page covered. Sending it to/instead would preserve today's behavior exactly.2. Deleting a page broke the Vale check, and this was the first PR to do it. That's a regression from #2591:
all_changed_and_modified_filesis ACMRDTUX and includes deleted paths, and Vale exits non-zero on a path that isn't there.fail_on_error: falsedoesn't cover it, because it's an invocation error rather than a lint finding. Before #2591 the broken file list made the action lint the whole repo, so this never surfaced.all_changed_filesis ACMR, which excludes deletions. Green on the re-run, with the deleted path gone from the list: https://github.com/superfly/docs/actions/runs/39822989953The CI fix is in this PR because this is the only PR that reproduces the failure. Same fix for
sprites-docsis superfly/sprites-docs#276. Happy to split it out if you'd rather keep the content change clean.