Repository navigation
Lint only files that still exist, so deleting a page doesn't fail the check - #276
Merged
Merged
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same fix as superfly/docs#2594, which hit this in
superfly/docson the first PR to delete a page.all_changed_and_modified_filesis ACMRDTUX and includes deleted paths. Vale exits non-zero on a path that isn't there:fail_on_error: falsedoesn't cover that, because it's an invocation error rather than a lint finding. Before #275 the bad file list made the action lint the whole repo, so it never surfaced.all_changed_filesis ACMR, so deleted paths are excluded. Theany_changedgate on the next step already matches ACMR semantics, so it stays correct.Verified in
superfly/docson the PR that exposed it: https://github.com/superfly/docs/actions/runs/39822989953. Not reproducible here, since this PR deletes nothing.