Repository navigation
Fix the separator so Vale is passed a file list it can read - #274
Merged
Merged
Conversation
Same bug as superfly/docs#2590. tj-actions/changed-files emits a space-separated list, and the step told vale-action it was comma-separated, so Vale received one argument holding every path joined by spaces. Vale answers an unmatched path with an empty result and exit 0, so this check has reported nothing since it was set up in #264. Also fixes the one finding it should have caught: open-source to open source on the platform integrations page. docs-tracking#375
|
Preview deployment for your docs. Learn more about Mintlify Previews.
馃挕 Tip: Enable Automations to automatically generate PRs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same bug as superfly/docs#2590, found while diagnosing https://github.com/superfly/docs-tracking/issues/375.
tj-actions/changed-filesemits a space-separated list, and this step toldvale-actionit was comma-separated. The action split on a comma that wasn't there, so Vale received a single argument holding every path joined by spaces. Vale answers an unmatched path with an empty result and exit 0, so this check has reported nothing since it was set up in #264.Reproduced both ways with the same binary and config:
In
superfly/docsthe same one-line change produced that repo's first real Vale annotation.Also fixes the one finding this check should have caught:
open-sourcetoopen sourceon the platform integrations page, which was the only Vale finding in the repo.How to verify this one, since fixing that finding leaves nothing to annotate: the job log should show Vale invoked with each path as its own argument, and should no longer carry the
User-specified path (a.mdx b.mdx) is inwarning that revealed the bug.fetch-depth: 2on the checkout step is a separate, smaller problem in both repos, tracked in https://github.com/superfly/docs-tracking/issues/377