Repository navigation
Give the Vale workflow enough history to find the merge base - #275
Merged
Merged
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same two fixes as superfly/docs#2591, for https://github.com/superfly/docs-tracking/issues/377. Supersedes the separator line I merged in #274.
fetch-depth: 0sochanged-filescan find the merge base. Verified: noUnable to find merge basein https://github.com/superfly/sprites-docs/actions/runs/39659199187.vale-actiontrims theseparatorinput, so the space I set in Fix the separator so Vale is passed a file list it can read #274 trims to empty, nothing splits, and it silently lints the whole repo instead.json: trueplusescape_json: falseis the shape it parses.Verification gap: this PR changes no
.mdor.mdx, so the Vale step is gated off and the file list isn't exercised here. #2591 proves it insuperfly/docswith the same action versions and inputs; the only difference in this repo is the glob filter and theany_changedgate. I checked this repo for British spellings and doubled words to find a prose fix to test with, and found none; Vale currently reports nothing here either.If the array ever fails to parse, the action falls back to linting everything, so the worst case is a noisy run, not the silent one from https://github.com/superfly/docs-tracking/issues/375.