Repository navigation
Remove ExplicitExpectsMockMethodRule as too specific - #364
Merged
Merged
Conversation
TomasVotruba
enabled auto-merge (squash)
October 13, 2026 20:28
TomasVotruba
force-pushed
the
remove-explicit-expects-mock-rule
branch
from
October 13, 2026 20:30
1965eef to
16f997e
Compare
TomasVotruba
disabled auto-merge
October 13, 2026 20:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
ExplicitExpectsMockMethodRule, which flagged every PHPUnit mock->method()call inside a test class that lacked an explicit->expects(...).Too specific/opinionated for a general rule set. Drops the rule, its config registration in
mock-rules.neon, its tests, thephpunit.xmlfixture excludes, and the README section.