Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 0 additions & 41 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3039,47 +3039,6 @@ final class SomeTest extends TestCase

<br>

### ExplicitExpectsMockMethodRule

PHPUnit mock method is missing explicit `expects()`, e.g. `$this->mock->expects($this->once())->...`. This is required since PHPUnit 12 to avoid silent stubs.

```php
use PHPUnit\Framework\TestCase;

final class SomeTest extends TestCase
{
public function test(): void
{
$mock = $this->createMock(\stdClass::class);
$mock->method('someMethod')->willReturn('value');
}
}
```

:x:

<br>

```php
use PHPUnit\Framework\TestCase;

final class SomeTest extends TestCase
{
public function test(): void
{
$mock = $this->createMock(\stdClass::class);

$mock->expects($this->atLeastOnce())
->method('someMethod')
->willReturn('value');
}
}
```

:+1:

<br>

### AvoidAnyExpectsRule

Disallow usage of `any()` expectation in mocks to ensure that all mock interactions are explicitly defined and verified.
Expand Down
3 changes: 0 additions & 3 deletions config/mock-rules.neon
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ conditionalTags:
phpstan.rules.rule: %symplify.mocks%

# explicit expects()
Symplify\PHPStanRules\Rules\PHPUnit\ExplicitExpectsMockMethodRule:
phpstan.rules.rule: %symplify.mocks%
Symplify\PHPStanRules\Rules\PHPUnit\AvoidAnyExpectsRule:
phpstan.rules.rule: %symplify.mocks%
Symplify\PHPStanRules\Rules\PHPUnit\NoWithOnStubRule:
Expand All @@ -30,7 +28,6 @@ conditionalTags:
services:
- Symplify\PHPStanRules\Rules\PHPUnit\NoMockObjectAndRealObjectPropertyRule
- Symplify\PHPStanRules\Rules\PHPUnit\NoDoubleConsecutiveTestMockRule
- Symplify\PHPStanRules\Rules\PHPUnit\ExplicitExpectsMockMethodRule
- Symplify\PHPStanRules\Rules\PHPUnit\AvoidAnyExpectsRule
- Symplify\PHPStanRules\Rules\PHPUnit\NoWithOnStubRule
- Symplify\PHPStanRules\Rules\PHPUnit\RequireAtLeastOneRule
Expand Down
2 changes: 0 additions & 2 deletions phpunit.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@
<exclude>tests/Rules/PHPUnit/PublicStaticDataProviderRule</exclude>
<exclude>tests/Rules/PHPUnit/NoAssertFuncCallInTestsRule/Fixture</exclude>
<exclude>tests/Rules/PHPUnit/NoMockOnlyTestRule/Fixture/SkipConstraintValidatorTest.php</exclude>
<exclude>tests/Rules/PHPUnit/ExplicitExpectsMockMethodRule/Fixture/SkipMockWithExpectsTest.php</exclude>
<exclude>tests/Rules/PHPUnit/ExplicitExpectsMockMethodRule/Fixture/MockWithoutExpectsTest.php</exclude>
<exclude>tests/Rules/PHPUnit/AvoidAnyExpectsRule/Fixture/SomeAnyTest.php</exclude>
<exclude>tests/Rules/PHPUnit/NoWithOnStubRule/Fixture/StubWithWithTest.php</exclude>
<exclude>tests/Rules/PHPUnit/NoWithOnStubRule/Fixture/SkipMockWithExpectsAndWithTest.php</exclude>
Expand Down
64 changes: 0 additions & 64 deletions src/Rules/PHPUnit/ExplicitExpectsMockMethodRule.php

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading