Skip to content

Add failing fixture for an imported @see test class in SeeAnnotationToTestRule - #378

Closed
Brainshaker95 wants to merge 1 commit into
symplify:mainfrom
Brainshaker95:see-annotation-imported-test
Closed

Brainshaker95 wants to merge 1 commit into
symplify:mainfrom
Brainshaker95:see-annotation-imported-test

Conversation

@Brainshaker95

Copy link
Copy Markdown
Contributor

Failing fixture for #377, as asked.

SkipImportedSee imports its test class and references it by its short name in @see.
The rule still reports the annotation as missing, because the raw tag text reaches is_a() unresolved.

@TomasVotruba

Copy link
Copy Markdown
Member

Thanks @Brainshaker95! Folded your fixture into #379 with the fix (resolving the @see tag through the docblock name scope). Closing in favor of that.

@TomasVotruba

Copy link
Copy Markdown
Member

Cherry picked in #378

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants