Repository navigation
Resolve imported short @see class names in SeeAnnotationToTestRule - #379
Merged
Merged
Conversation
Contributor
|
Thanks! |
Member
Author
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #377. Supersedes #378 (keeps its failing fixture by @Brainshaker95).
SeeAnnotationToTestRulehanded the raw@seetag text straight tois_a(), so a short, imported class name (e.g.@see UserMailerTestwith auseimport) never matched and the class was wrongly reported as missing its test annotation.The raw text is now resolved through the docblock name scope (
ResolvedPhpDocBlock::getNullableNameScope()->resolveStringName()) before theis_a()check, so both fully qualified and imported short names work. FQCN annotations keep working unchanged.Same issue and fix approach as rectorphp/rector-phpunit#779.