Repository navigation
Security fixes - #719
Merged
Merged
Security fixes#719
Conversation
1technophile
left a comment
1technophile
left a comment
Member
There was a problem hiding this comment.
The changes address the reported F1–F5 paths. I replayed 14 cases against 7153ffa with AddressSanitizer and UndefinedBehaviorSanitizer; all completed without sanitizer errors, and valid properties remained available when another data source was truncated.
One remaining improvement: reset errno before strtod() and reject ERANGE afterward. Currently, 1e9999 produces "windspeed":null and 1e-999 produces "windspeed":0 instead of skipping the invalid reading.
This was referenced Oct 13, 2026
3 tasks done
1technophile
added a commit
to theengs/app
that referenced
this pull request
Oct 21, 2026
Moves thirdparty/TheengsDecoder from v2.3.0 to v2.5.0, which brings the upstream fixes from theengs/decoder#719 plus the v2.4.x additions (Victron SmartShunt / Orion TR / battery monitors, Schneider Odace WLBL, SwitchBot Meter Pro without CO2, and the "bvpp" primary-property tag). Co-authored-by: Florian <1technophile@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported by Tom Watson
Checklist: