Repository navigation
fix(threads): pin tinyagents with the SQLite conversation append fix - #8360
Conversation
Every thread message append on the default SQLite backend was refused with "unsupported capability conditional_stream_append": TinyAgents' admit_append required that capability from the document port, while SQLite advertises it only on its stream port (the one the append uses). tinyhumansai/tinyagents#572 checks each capability on the port that uses it. Move vendor/tinyagents 1f24dbe -> 540997d (tinyhumansai#572's merge, tinyagents main; a fast-forward of tinyhumansai#572's commits only, no manifest change) and keep the reproduction as a regression test: a plain message appends on a workspace opened on the production default backend kind (SQLite).
Tiny Sweeper reviewReviewed head: Verdict: Ready for maintainer review · Priority: none Diagnostics and supporting detailsFull summaryPull request purpose (title): fix(threads): pin tinyagents with the SQLite conversation append fix. This PR pins tinyagents from `1f24dbe` to `540997d` (the merge of tinyhumansai/tinyagents#572) so that conversation message appends on the production SQLite backend stop failing with `unsupported capability conditional_stream_append`, and adds a regression test that exercises the append path against the persistent default backend kind. The visible diff adds only a test; the vendor submodule bump is not visible in the diff, so the pin and the upstream fix it claims were not directly verifiable. Unreviewed paths
Review snapshot
Completeness: Complete FeaturesNone identified with supported citations. TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. FindingsNo active actionable findings. Before mergeNone. Agent review detailscritique
security
tests
commits
description
Evidence and run details
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly identifies the main change: pinning the TinyAgents revision that fixes SQLite conversation append behavior. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit checks the SQLite stream,
A plain message joins the scene.
The thread is made, the append is tried,
A TinyAgents pointer shifts beside.
Soft paws mark the test complete,
Then hop away on quiet feet.
Comment @coderabbitai help to get the list of available commands.
![tinysweeper[bot]](https://avatars.githubusercontent.com/in/4526585?s=60&v=4){kind=small}
tinysweeper
Bot
added
the
priority: p3
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ca4dc84f2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
backend_for prefers a process-installed backend over the workspace default, and other tests install an in-memory backend (which lists every capability) under lock_storage_slot. Hold that lock for the whole test and assert nothing is installed, so the append provably runs on the workspace's SQLite default and cannot pass on memory.
Summary
On main, every thread message append on the default SQLite backend fails with
unsupported capability conditional_stream_append: conversation append requires checked documents and conditional streams. That covers the UI'sthreads_message_append(threads/ops/crud.rs), the channel host adapters, the relay store and subagent delivery, which all go through TinyAgents'DriverConversationStoreoverstorage::local::backend_for. Production opens asqlite:default there.Cause (upstream). TinyAgents'
admit_appendrequiredConditionalStreamAppendfrom the document port. tinystoragedrivers' SQLite driver advertises it only on its stream port, the one the append writes through. tinyhumansai/tinyagents#572 checks each capability on the port that uses it.This PR
vendor/tinyagents:1f24dbe→540997d(Fix Telegram chat failure: skills not linking/routing correctly #572's merge, tinyagentsmain). A fast-forward of Fix Telegram chat failure: skills not linking/routing correctly #572's commits only, with no manifest or vendor change.threads::ops::crud::message_append_tests::a_message_appends_on_a_sqlite_workspace(storage-sqlite): a plain message appends on a workspace opened withuse_persistent_default_for_test, i.e. the production backend kind, not the in-memory test default. The memory backend lists every capability, which is why no existing test caught this.Tests
On the CI host:
Summary by CodeRabbit