[M3gA-Mind]

Summary

Stacked on #8361 (fix/raw-coverage-build-on-main, by W2), which makes the openhuman-cli raw_coverage_all target compile. Until #8361 merges, this PR's diff also shows #8361's commits. This PR's own change is the last commit, c680d09: 3 files, +19 −2.

Fixes automation_scheduling_e2e::cron_run_records_history_and_remove_is_not_idempotent. Once the target compiles, it fails even when run CI-faithfully (test modules installed, full product features, one module per process). The shell job's run record is status: "error", output: "Command execution is unavailable.".

Root cause, from a traced run on the CI host.

1. A cron shell job runs through the TinyBox module (sandbox::shell_exec::run_owned → tinybox::create, passthrough backend).
2. Before creating the command resource, TinyBox asks host storage for its capabilities: [storage_host] module storage call module=tinybox … op=Capabilities outcome="no-backend". It treats that as fatal (reason="module_fault"), so create fails with "MODULE_CALL_REPORTED: module execution failed".
3. no-backend happens because nothing installed a process storage backend. A real host's boot fills the slot (openhuman-rpc server/shims.rs → session_store::install_for_host). This suite builds the router directly and boots no host. The suite crate already provides HostStorage for exactly this, documented as "modules reach host storage only through the installed backend … these suites boot none", and the composio suites use it. The cron test did not.

Fix

• The cron test installs crate::HostStorage under its env lock.
• Observability: both places that swallowed the cause now log it at warn.
  • cron/scheduler/shell_job.rs logs the run_host error with the job id. The recorded output stays "Command execution is unavailable.".
  • sandbox/shell_exec.rs logs the module's error from the TinyBox create call.

Before this, neither a user nor CI could tell why a cron shell job failed.

Tests

On the CI host, CI-faithful, --test raw_coverage_all -- automation_scheduling_e2e::… --test-threads=1:

• RED on main + fix(tests): build raw_coverage_all and inbound_linked_e2e against main #8361: fails as above.
• GREEN with this PR.

Summary by CodeRabbit

• Bug Fixes
  • Added warning and error details to logs when shell command execution or resource setup fails. The existing error messages remain unchanged.
• Tests
  • Updated automated tests for storage, scheduled shell jobs, and inference controllers to use current test interfaces and configurations.

[tinysweeper]

Tiny Sweeper review

Reviewed head: c680d09311447c57aaea7a28f3414faeca087183

Findings

No active actionable findings.

Advisory notes

• medium: Mention that the diff swaps in a new testkit storage dependency ((pull request description))
  Problem: The PR body says the change is "3 files, +19 −2" and describes only two `tracing::warn!` additions plus a storage install in the cron test. The diff actually does much more:
  Suggested fix:
  No concrete fix was supplied.

Verdict: Ready for maintainer review · Priority: medium
Coverage: Reviewed 7 of 8 files; not reviewed: Cargo.lock.

Diagnostics and supporting details

Full summary

Pull request purpose (title): fix(cron): log why a shell job could not run; give the cron e2e host storage. Tiny Sweeper completed its review; deterministic results follow.

Unreviewed paths

• Cargo.lock

Review snapshot

Change surface	Files	Review signal	Count
Production	2	Active findings	0
Tests	4	Noted findings	1
Documentation	0	Resolved findings	0
Configuration	1	Pending checks/questions	0

Completeness: Complete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

What changed

Behaviorally, the cron shell-job path and sandbox shell path now emit `tracing::warn!` diagnostics when they previously discarded the underlying error: `run_job_command_with_timeout` in `crates/openhuman-core/src/cron/scheduler/shell_job.rs#pub(super) async fn run_job_command_with_timeout(` logs the `run_host` error with the job id while still returning "Command execution is unavailable.", and `run_owned` in `crates/openhuman-core/src/sandbox/shell_exec.rs#async fn run_owned(` logs the TinyBox `create` error before mapping it to the same anyhow message.

Features

• Modified — Warn-level diagnostics when a cron shell job cannot run: Previously the underlying `run_host` error was silently discarded and only "Command execution is unavailable." was recorded; now the error is logged with the job id via `tracing::warn!`, while the user-visible recorded output is unchanged. (crates/openhuman-core/src/cron/scheduler/shell_job.rs pub(super) async fn run_job_command_with_timeout()
• Modified — Warn-level diagnostics when TinyBox refuses to create a command resource: The error from the TinyBox `create` call is now logged before being mapped to the same anyhow error, surfacing the cause of `module_fault` failures that were previously opaque. (crates/openhuman-core/src/sandbox/shell_exec.rs async fn run_owned()
• Modified — Test storage backend swapped to tinystoragedrivers_testkit::MemoryBackend: Test harnesses now install `MemoryBackend` instead of `openhuman_core::storage::MemoryStorage`, with a new git dependency declared in the CLI manifest. (tests/raw_coverage_all.rs pub struct HostStorage<'lock>(std::marker::PhantomData<&'lock ()>);, tests/inbound_linked_e2e.rs async fn linked_tinyeventqueues_queues_dedupes_and_delivers_a_composio_trigger(), crates/openhuman-cli/Cargo.toml tinyinference-llm = { path = "../../vendor/tinyagents/vendor/tinyinference/crate)

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Before merge

None.

Agent review details

critique

• Conclusion: Success
• Scope reviewed: all assigned evidence
• Positive: The critique lane is Answered and reports reviewing 7 files with 0 findings.
• Lane summary: Reviewed 7 files; 0 findings. _The code index is behind this pull request (indexed at `d1124cc18c4d`), so retrieved context may be out of date._

security

• Conclusion: Success
• Scope reviewed: all assigned evidence
• Positive: The security lane is Answered and reports reviewing 7 files with 0 findings.
• Lane summary: Reviewed 7 files; 0 findings. _The code index is behind this pull request (indexed at `d1124cc18c4d`), so retrieved context may be out of date._

tests

• Conclusion: Success
• Scope reviewed: all assigned evidence
• Positive: The tests lane is Answered with 0 findings and raised one caveat rather than a finding: whether `tinystoragedrivers-testkit` is visible to the `openhuman-cli` integration-test targets, since the manifest declares it unconditionally rather than under `[dev-dependencies]`.
• Lane summary: The change is diagnostic logging in two error arms plus test-only plumbing (swapping the test storage backend and adapting host-side tests to `ControllerEntry`), and the diff shows no behavioural regression, so nothing here needs a new test. One thing I could not verify: whether `tinystoragedrivers-testkit` is actually visible to the `openhuman-cli` integration-test targets that now call `tinystoragedrivers_testkit::MemoryBackend`, since `Cargo.toml` declares it unconditionally rather than under `[dev-dependencies]`; consult the manifest in-tree before merging. _The code index is behind this pull request (indexed at `d1124cc18c4d`), so retrieved context may be out of date._

commits

• Conclusion: Success
• Scope reviewed: all assigned evidence
• Positive: The commits lane is Answered and reports no sensitive content in committed files.
• Lane summary: No sensitive content in committed files. _The code index is behind this pull request (indexed at `d1124cc18c4d`), so retrieved context may be out of date._

description

• Conclusion: Success
• Scope reviewed: all assigned evidence
• Positive: The description lane further reports that the body presents the tests' `+19 −2` scope as if it were the whole diff, which it states is wrong, and that the unmentioned changes are significant and unrelated to the stated observability fix.
• Lane summary: The description is accurate about the last commit's intent — logging the swallowed error in `shell_job.rs` and `shell_exec.rs` — and about the cron test's storage install, but it never mentions that the diff also rewrites `tests/inbound_linked_e2e.rs` and `tests/raw_coverage_all.rs` to use `tinystoragedrivers_testkit::MemoryBackend` instead of `openhuman_core::storage::MemoryStorage` (adding that git dependency to `crates/openhuman-cli/Cargo.toml`), nor the substantial refactor of `tests/raw_coverage/inference_local_controllers_rpc_e2e.rs` to call controllers through `ControllerEntry`. Those changes are significant and unrelated to the stated observability fix, and the body also presents the tests' `+19 −2` scope as if that were the whole diff, which is wrong. _The code index is behind this pull request (indexed at `d1124cc18c4d`), so retrieved context may be out of date._

Evidence and run details

• Models: ladder/vectors-oai3, deepseek-v4.1-flash
• Spend: $0.001704
• Tokens: 529637 input · 9415 output · 100376 cached · 409 embedding
• Updated: 2026-10-24T02:41:31Z

Head	State	Pass summary
c680d0931144	ready for maintainer review	0 active finding(s), 0 resolved finding(s) (at 2026-10-24T02:41:31Z)

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-24T02:44:51.817031Z	c680d09	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 354747bd-ea6e-402c-af1a-f5eef9d79f0e

Commits

Reviewing files that changed from the base of the PR and between b92d845 and c680d09.

Files ignored due to path filters: 1

• Cargo.lock is excluded by !**/*.lock

Files selected for processing: 7

• crates/openhuman-cli/Cargo.toml
• crates/openhuman-core/src/cron/scheduler/shell_job.rs
• crates/openhuman-core/src/sandbox/shell_exec.rs
• tests/inbound_linked_e2e.rs
• tests/raw_coverage/automation_scheduling_e2e.rs
• tests/raw_coverage/inference_local_controllers_rpc_e2e.rs
• tests/raw_coverage_all.rs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

Walkthrough

The scheduler and shell execution code now log details for selected failures. Integration tests update storage backend setup and use ControllerEntry for core registry controller calls.

Changes: Runtime diagnostics

Layer / File(s)	Summary
Log command and resource creation failures crates/openhuman-core/src/cron/scheduler/shell_job.rs, crates/openhuman-core/src/sandbox/shell_exec.rs	The scheduler logs the job ID and formatted error when command execution fails. Shell execution logs the underlying error when TinyBox resource creation fails. Both paths retain their existing generic errors.

Integration test updates

Layer / File(s)	Summary
Install testkit storage backends crates/openhuman-cli/Cargo.toml, tests/inbound_linked_e2e.rs, tests/raw_coverage_all.rs, tests/raw_coverage/automation_scheduling_e2e.rs	The CLI manifest adds the testkit dev-dependency. Tests install MemoryBackend instead of MemoryStorage; the cron test installs HostStorage under the shared environment lock.
Invoke core controllers through registry entries tests/raw_coverage/inference_local_controllers_rpc_e2e.rs	Core registry tests look up controllers as ControllerEntry values and invoke them through the added helper. Local-runtime controller tests continue to use RegisteredController.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related issues

• Epic: tinystoragedrivers as a hardened static primitive (types + API + per-primitive crates, engines as features) #8131: The cron test now installs HostStorage, which supplies the host-provided backend described by the issue.

Possibly related PRs

• tinyhumansai/openhuman#8325: This PR updates the storage driver revision used by the testkit dependency added here.
• tinyhumansai/openhuman#8361: This PR includes the same testkit, storage backend, and ControllerEntry test changes.
• tinyhumansai/openhuman#8362: This PR includes the same testkit dependency and test migrations, including the HostStorage setup.

Suggested reviewers: senamakel

Merge Risk: Minimal · up to c680d

The changes preserve runtime behavior while improving diagnostics and aligning integration tests with current storage and controller APIs.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 45.45% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 6 files. (1 skipped: …	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly summarizes the main changes: it adds logging for failed cron shell jobs and configures host storage for the cron end-to-end test.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 45.45% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 6 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{A rabbit checks the logs at night,
And sees the errors written right.
Test backends settle in their place,
Registry calls run at a steady pace.
The rabbit hops, content and bright.}

_{Comment @coderabbitai help to get the list of available commands.}

[tinysweeper]

tinysweeper found nothing blocking. Approving.

Diagnostics

Total spend: $0.0017

The merge-base changed after approval.