Update tf_thaw_set in global_cycle - #1155
Merged
BrianCurtis-NOAA merged 2 commits intoMay 5, 2026
Merged
Conversation
Collaborator
|
Good afternoon Travis, could you bump to the latest version of develop branch? |
BrianCurtis-NOAA
approved these changes
May 5, 2026
DavidHuber-NOAA
pushed a commit
to DavidHuber-NOAA/UFS_UTILS
that referenced
this pull request
Jun 24, 2026
31 tasks
BrianCurtis-NOAA
pushed a commit
that referenced
this pull request
Jun 30, 2026
DavidHuber-NOAA
pushed a commit
to NOAA-EMC/global-workflow
that referenced
this pull request
Jul 6, 2026
#5088) This PR updates the UFS_UTILS hash to include ufs-community/UFS_UTILS#1155 in the dev/gfs.v17 branch. This resolves a global_cycle failure in debug mode found during GCAFS review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Compiling with debug mode and running tests for the GCAFS NCO stability tests, highlighted a failure for an undefined is_ice variable in the
tf_thaw_setsubroutine ofsorc/global_cycle.fd/cycle.F90. This PR adds a default value ofis_ice=.false. to thetf_thaw_setsubroutine. This line is already included in theADJUST_NSSTsubroutine which uses a similar algorithm.TESTING
WHICH CONSISTENCY TESTS TO RUN:
TESTS CONDUCTED:
DOCUMENTATION:
LINKED ISSUES:
Resolves #1151