Skip to content

update g2tmpl version - #3113

Open
lipan-NOAA wants to merge 9 commits into
ufs-community:developfrom
lipan-NOAA:develop
Open

update g2tmpl version#3113
lipan-NOAA wants to merge 9 commits into
ufs-community:developfrom
lipan-NOAA:develop

Conversation

@lipan-NOAA

@lipan-NOAA lipan-NOAA commented Mar 2, 2026

Copy link
Copy Markdown
Collaborator

Commit Queue Requirements:

  • This PR addresses a relevant WM issue Update UPP and g2tmpl versions to support GCAFS implementation. #3111
  • All subcomponent pull requests (if any) have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
    • Commit log file w/full results from RT suite run (if applicable).
    • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
  • Fill out all sections of this template.

Description:

For the implementation of GCAFS, the g2tmpl version needs to be updated from 1.13.0 to 1.16.0 to avoid a large number of warning messages in the GCAFS prediction

Commit Message:

* UFSWM - 
  * UFSATM - 

Priority:

  • Critical Bugfix: For GCAFS v1.0 code delivery and implementation
  • High: For GCAFS v1.0 code delivery and implementation
  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • Blocked by #
  • None

Documentation:

  • Documentation update required.
    • Relevant updates are included with this PR.

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Updates/Changes Baselines.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • Required
    • Library names w/versions: g2tmpl/v1.16.0

Testing Log:

  • RDHPCS
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

Testing Remarks:

@github-project-automation github-project-automation Bot moved this to Evaluating in PRs to Process Mar 2, 2026
@gspetro-NOAA gspetro-NOAA moved this from Evaluating to Pre-testing required in PRs to Process Mar 2, 2026
@gspetro-NOAA gspetro-NOAA added Baseline Updates Current baselines will be updated. UFSATM There are changes to the UFSATM repository. UPP There are changes to the UPP component repository. Priority: High labels Mar 2, 2026
@gspetro-NOAA

gspetro-NOAA commented Mar 2, 2026

Copy link
Copy Markdown
Collaborator

@lipan-NOAA I think you need to update the hash in your WM branch to point to the most recent commit on your fork's branch (5e64b26).

We will also need you to:

  • Push the logs and test_changes.list file from a full run of the RT suite (preferably on Ursa).
  • Add a commit message (for WM & UFSATM)

@DeniseWorthen

DeniseWorthen commented Mar 2, 2026

Copy link
Copy Markdown
Collaborator

@lipan-NOAA Could you please say which Regression tests you are using for your implementation configuration? For each implementation target, there should be an associated set of UWM Regression tests. So for example, we have these for V17

RUN | cpld_control_gfsv17                               | - noaacloud                          | baseline |
RUN | cpld_control_gfsv17_iau                           | - noaacloud                          | baseline | cpld_control_gfsv17
RUN | cpld_restart_gfsv17                               | - noaacloud                          |          | cpld_control_gfsv17
RUN | cpld_restart_gfsv17_iau                           | - noaacloud                          |          | cpld_control_gfsv17_iau
RUN | cpld_mpi_gfsv17                                   | - noaacloud                          |          |
RUN | cpld_debug_gfsv17                                 | - noaacloud                          | baseline |

Each of these tests is used to ensure that the operational requirements (debug, reproducibility, restart reproducibility etc) is constantly tested for.

There should be a analogous set of tests in UWM for your GCAFSv1.0. So what tests are you using?

@lipan-NOAA

Copy link
Copy Markdown
Collaborator Author

@DeniseWorthen Regression tests were performed on cpld_control_gfsv17, cpld_control_gfsv17_iau, cpld_restart_gfsv17, cpld_restart_gfsv17_iau and cpld_mpi_gfsv17, and all results were passed; Regression tests were also performed on atmaero_control_p8, atmaero_control_p8_rad and atmaero_control_p8_rad_micro, with p8 test passing and two "p8_rad" failing.

@DeniseWorthen

Copy link
Copy Markdown
Collaborator

@lipan-NOAA Is g2tmpl 1.16.0 available on RDHPCS platforms?

@lipan-NOAA

Copy link
Copy Markdown
Collaborator Author

@DeniseWorthen Besides version 1.13.0, there are newer versions available on the RDHPCS platform. I checked gaea C6, and g2tmpl version 1.17.0 is available, but it requires modules to use a newer version of spack-stack, which may require other library versions to be changed as well.

@bbakernoaa

Copy link
Copy Markdown
Collaborator

@DeniseWorthen Can we get a product branch made for GCAFSv1? This would allow us to proceed forward quicker

@dpsarmie

dpsarmie commented Mar 3, 2026

Copy link
Copy Markdown
Collaborator

@DeniseWorthen Can we get a product branch made for GCAFSv1? This would allow us to proceed forward quicker

I can try to take care of that. I'm going to be doing something similar for Bin with HAFS2.2. Where is the GCAFS repo so I can start to take a look? We can follow-up offline so we don't clutter this PR.

@bbakernoaa

bbakernoaa commented Mar 3, 2026

Copy link
Copy Markdown
Collaborator

We don’t have a separate GCAFS repo. We are simply part of global-workflow which adds the ufswm as a submodule. @aerorahul can you help clarify what specifically we need to do for operations.

We have a dev/gcafs.v1 branch of global workflow which will be delivered to NCO. https://github.com/NOAA-EMC/global-workflow/tree/dev/gfs.v16

@dpsarmie

dpsarmie commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

Ok, that should be simple enough. From the dev/gcafs.v1 branch of GW (https://github.com/NOAA-EMC/global-workflow/tree/dev/gcafs.v1) it looks like you're using the following UFSWM hash: https://github.com/ufs-community/ufs-weather-model/tree/6f22f57403db693dee3b6979a4e6f58ade633e86

I'll make a production/GCAFS.v1.0 branch in the UFS repo off of that hash. We can then add these changes as a GCAFS prod only change and then open a PR on the GW side to update the UFSWM hash.

Does that all seem ok @bbakernoaa ?

@gspetro-NOAA gspetro-NOAA moved this from Pre-testing required to Evaluating in PRs to Process Mar 10, 2026
@gspetro-NOAA gspetro-NOAA moved this from Evaluating to Pre-testing required in PRs to Process Mar 10, 2026
@gspetro-NOAA

gspetro-NOAA commented Apr 2, 2026

Copy link
Copy Markdown
Collaborator

@lipan-NOAA Could you sync w/develop so that I can perform some testing? g2tmpl 1.16.0 has been added to spack-stack v1.9.2 on RDHPCS.

EDIT: Nevermind! Looks like it's a straightforward update, so I could just click the "Update" button.

@gspetro-NOAA gspetro-NOAA moved this from Pre-testing required to On Pause in PRs to Process May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Baseline Updates Current baselines will be updated. Priority: High UFSATM There are changes to the UFSATM repository. UPP There are changes to the UPP component repository.

Projects

Status: On Pause

Development

Successfully merging this pull request may close these issues.

Update UPP and g2tmpl versions to support GCAFS implementation.

5 participants