Repository navigation
Tolerate a drawable without a skin when fencing a position - #2
Merged
Merged
Conversation
A target can move while its skin is still loading or after the skin was destroyed. getFencedPositionOfDrawable already tolerated a missing drawable but dereferenced the skin unconditionally, so a "go to" block on such a target threw "Cannot read properties of undefined (reading 'getFenceBounds')". Keep the requested position when there is nothing to fence against. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A target can move while its skin is still loading or after the skin was destroyed.
getFencedPositionOfDrawablealready tolerated a missing drawable but dereferenceddrawable._skinunconditionally, so ago toblock on such a target threw "Cannot read properties of undefined (reading 'getFenceBounds')" (seen with the Canvas extension). With no skin there is nothing to fence against, so the requested position is returned unchanged.Unit test added; the tap unit and integration suites pass locally after a build. No visible change, so no screenshots.