Skip to content

Tolerate a drawable without a skin when fencing a position #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mistium merged 1 commit into from
Sep 24, 2026
Merged

Tolerate a drawable without a skin when fencing a position #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/RenderWebGL.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1880,9 +1880,16 @@ class RenderWebGL extends EventEmitter {
return [x, y];
}

const skin = drawable._skin;
if (!skin) {
// A target can move while its skin is still loading or after it was destroyed.
// There is nothing to fence against, so keep the requested position.
return [x, y];
}

const dx = x - drawable._position[0];
const dy = y - drawable._position[1];
const aabb = drawable._skin.getFenceBounds(drawable, __fenceBounds);
const aabb = skin.getFenceBounds(drawable, __fenceBounds);
const inset = Math.floor(Math.min(aabb.width, aabb.height) / 2);

const sx = this._xRight - Math.min(FENCE_WIDTH, inset);
Expand Down
8 changes: 8 additions & 0 deletions test/unit/RenderWebGLOptimizationTests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,11 @@ test('skin sizes tolerate asynchronous loading and destroyed skins', t => {
t.same(renderer.getSkinSize(123), [0, 0]);
t.end();
});

test('fencing keeps the requested position while a drawable has no skin', t => {
const renderer = Object.create(RenderWebGL.prototype);
renderer._allDrawables = [{_position: [0, 0], _skin: null}];
t.same(renderer.getFencedPositionOfDrawable(0, [500, -400]), [500, -400]);
t.same(renderer.getFencedPositionOfDrawable(7, [12, 34]), [12, 34]);
t.end();
});
Loading