Repository navigation
fix: support inline code facets in observability templates - #410
Closed
max-braintrust wants to merge 1 commit into
Closed
max-braintrust wants to merge 1 commit into
max-braintrust wants to merge 1 commit into
Conversation
This was referenced Oct 8, 2026
Contributor
|
Latest downloadable build artifacts for this PR commit
Available artifact names
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standalone PR. It is not required by #411 or #409.
Some facets store inline code in
function_data. Observability template pull rejects them with “has facet type but non-facet function_data”, and push also rejects them during validation.This PR accepts extraction prompt facets and inline code facets. Pull and push preserve the code, runtime settings, code hash, and tags. Bundled code remains unsupported; the error explains that templates cannot package it and suggests inline code.
Checks: 18
active_observabilitytests passed, including an inline code export → JSON → import-plan round trip and rejection of bundled, malformed, and unrelated function data. Cargo formatting and README Prettier passed. Clippy passed with the existing root command enum'slarge_enum_variantwarning suppressed.