Repository navigation
fix: replace Topics map bindings within the selected automation - #411
Merged
Stephen Belanger (Qard) merged 6 commits intoOct 15, 2026
Merged
Conversation
This was referenced Oct 8, 2026
Contributor
|
Latest downloadable build artifacts for this PR commit
Available artifact names
|
max-braintrust
force-pushed
the
max/observability-duplicate-topic-map-repair
branch
from
October 13, 2026 17:02
b3261bb to
494b7e4
Compare
max-braintrust
changed the base branch from
max/observability-inline-code-facets
to
main
October 13, 2026 17:02
max-braintrust
changed the title
max-braintrust
marked this pull request as ready for review
October 13, 2026 22:38
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Stephen Belanger (Qard)
approved these changes
Oct 15, 2026
Stephen Belanger (Qard)
deleted the
max/observability-duplicate-topic-map-repair
branch
October 15, 2026 09:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 1/2. Base:
main. Next: scoped Topics settings (#409). Review and merge this PR first.Older template pushes could attach another map when a facet already had one under a different slug. Later pushes failed on those multiple maps. Repair also removed the facet and map from other automations, even when those bindings were valid.
With
--force, push selects the map with the generated template slug, or creates it if needed. It detaches superseded maps only from the selected destination automation. Other automations keep their facet and map bindings.An existing matching map retains its customization and saved state. A newly created map needs generation before it can classify. Push does not regenerate topics or replay historical classifications.
Detached map functions remain in the project and are listed in human and JSON output. They may still be referenced by other automations.
The removal planner takes only the destination mutations, selected destination key, and superseded maps. Its four unused parameters have been removed.
Checks: 17 focused
active_observabilitytests passed, including selected-map replacement and preservation of another automation's shared-facet binding. Cargo formatting andgit diff --checkpassed. Both branches include current main.