Repository navigation
fix: resolve links in templates after Needs are frozen - #982
Merged
Merged
Conversation
get_needs_mutable() raises once Sphinx-Needs has post-processed the Needs. The score-report-pie handler runs in doctree-resolved, where the status and coverage filter functions call req_in_report_version for a scoped report. For a comp_req without valid_from that follows derived_from through _get_available_needs() and crashed the build. Use the read-only view once the Needs are frozen.
antonkri
requested review from
AlexanderLanin,
MaximilianSoerenPollak,
a-zw,
dcalavrezo-qorix and
nradakovic
as code owners
October 20, 2026 09:40
Contributor
|
Documentation preview for this pull request is available at: |
nradakovic
approved these changes
Oct 20, 2026
This was referenced Oct 20, 2026
Merged
antonkri
added a commit
to eclipse-score/persistency
that referenced
this pull request
Oct 20, 2026
Pin score_docs_as_code via git_override to docs-as-code main at 1f9452a270d238f7504c7a053b3886536234a650, which includes eclipse-score/docs-as-code#982 (fixes the "Needs have already been post-processed and frozen" crash of the version-scoped report pies). Bump score_process_description to 2.2.1 to match the resolved version and update MODULE.bazel.lock accordingly.
antonkri
added a commit
to eclipse-score/lifecycle
that referenced
this pull request
Oct 20, 2026
Pin score_docs_as_code via git_override to docs-as-code main at 1f9452a270d238f7504c7a053b3886536234a650, which includes eclipse-score/docs-as-code#982 (fixes the "Needs have already been post-processed and frozen" crash of the version-scoped report pies). Bump score_process_description to 2.2.1 and score_tooling to 2.2.2 to match the resolved versions and update MODULE.bazel.lock accordingly.
antonkri
added a commit
to eclipse-score/logging
that referenced
this pull request
Oct 20, 2026
Pin score_docs_as_code via git_override to docs-as-code main at 1f9452a270d238f7504c7a053b3886536234a650, which includes eclipse-score/docs-as-code#982 (fixes the "Needs have already been post-processed and frozen" crash of the version-scoped report pies). Bump score_process_description to 2.2.1 to match the resolved version and update MODULE.bazel.lock accordingly.
etas-contrib-automation Bot
pushed a commit
to etas-contrib/score_persistency
that referenced
this pull request
Oct 20, 2026
…lipse-score#537) * docs: use mod_ver_report need type for module verification report * chore: pin score_docs_as_code to docs-as-code main Pin score_docs_as_code via git_override to docs-as-code main at 1f9452a270d238f7504c7a053b3886536234a650, which includes eclipse-score/docs-as-code#982 (fixes the "Needs have already been post-processed and frozen" crash of the version-scoped report pies). Bump score_process_description to 2.2.1 to match the resolved version and update MODULE.bazel.lock accordingly.
rmaddikery
pushed a commit
to eclipse-score/logging
that referenced
this pull request
Oct 21, 2026
Pin score_docs_as_code via git_override to docs-as-code main at 1f9452a270d238f7504c7a053b3886536234a650, which includes eclipse-score/docs-as-code#982 (fixes the "Needs have already been post-processed and frozen" crash of the version-scoped report pies). Bump score_process_description to 2.2.1 to match the resolved version and update MODULE.bazel.lock accordingly.
cameron-craig-etas
pushed a commit
to etas-contrib/score_lifecycle
that referenced
this pull request
Oct 21, 2026
…lipse-score#820) * docs: use mod_ver_report need type for module verification report * chore: pin score_docs_as_code to docs-as-code main Pin score_docs_as_code via git_override to docs-as-code main at 1f9452a270d238f7504c7a053b3886536234a650, which includes eclipse-score/docs-as-code#982 (fixes the "Needs have already been post-processed and frozen" crash of the version-scoped report pies). Bump score_process_description to 2.2.1 and score_tooling to 2.2.2 to match the resolved versions and update MODULE.bazel.lock accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a docs build crash seen in eclipse-score/baselibs#672 with docs-as-code
main:Cause: since #949 the module report pies count through the
score_metricsfilterfunctions and pass the module version. Those functions run in
doctree-resolved, afterSphinx-Needs has frozen the Needs. With a version set,
req_in_report_versionresolvesderived_fromof acomp_reqwithoutvalid_fromthrough_get_available_needs(), whichalways called
get_needs_mutable()and raises in the write phase. Reports without a version(e.g. reference_integration) never reach that path, which is why it went unnoticed.
Fix:
_get_available_needs()uses the read-onlyget_needs_view()once the Needs arepost-processed, and
get_needs_mutable()before (callingget_needs_view()earlier wouldfreeze them prematurely).
A new test covers both states; it fails with the same
RuntimeErrorwithout the fix.