[fclairamb]

Specs filed from the daily security scans. Each spec is the tracker for its finding. This PR adds the specs and implements them.

What changed

• V1: the device consent page now shows when the request was opened, the requester's IP and client, the approver's IP and a "different network" hint, a warning above Approve, and a required "I started this sign-in myself" checkbox when the code arrived pre-filled in the URL. The approver gets an email after approving. New migration 031_v0_43_0 stores the requester IP and user agent.
• W1: DELETE /auth/2fa spends the shared per-user 2FA budget (5 per 15 minutes) before comparing the code, answers 429 RATE_LIMITED, and resets on success. The dash0 dialog shows the message, and no longer refreshes and retries on a wrong code.
• Batch gate green: backend build, lint and tests, dash0 typecheck and lint, Playwright 980 passed, 15 skipped.

Decided by autopilot

• V1, pre-filled code needs a second confirmation?: checkbox only, no retyping (spec's recommended answer).

Specs (now implemented, archived in specs/done/2026/10/)

• V1 (medium): specs/done/2026/10/2026-10-27-01-device-consent-phishing-guard.md. The device-flow consent page approves a code anyone can mint without an account and send by link, already filled in. It shows no warning to approve only a sign-in you started yourself, and no detail about who opened the request. One click from a signed-in member gives the requester a 90-day PAT with the member's role. The fix adds the requester's details, a warning and an email notification, and keeps the CLI flow one click.
• W1 (low): specs/done/2026/10/2026-10-27-02-disable-2fa-attempt-throttle.md. DELETE /auth/2fa checks the TOTP code without the per-user attempt budget that login 2FA uses. Someone holding a stolen session or PAT can guess the code at the global request rate and remove the second factor for good. The fix spends the shared 2FA budget before comparing.

Earlier scan specs (implemented, in specs/done/2026/10/)

• U1 (low): 2026-10-26-02-ai-repair-hold-skips-param-only-secrets.md. The repair: auto hold applied only when the check's secrets map had a value. Fixed in fix(ai): hold every scheduled repair-auto run to its granted hosts #683.
• S1 (medium): 2026-10-25-01-ai-repair-grant-dropped-by-reference-resolution.md. The repair grant was compared after ${…} references were resolved. Fixed in fix(ai): hold the repair: auto host grant when the script or env holds a reference #678; U1 closed the remaining gap.
• R1 (medium): 2026-10-24-01-ai-repair-auto-apply-partial-runtime-host.md. repair: auto applied a candidate that kept a literal host and added one built at runtime. Fixed in feat(ai): hold auto-applied repairs to the previous version's hosts (+ scan specs) #663.
• Q1 (medium): 2026-10-23-02-ai-loop-secret-relay-through-model.md. AI loops relayed an encoded secret through the model.
• P1 (medium): 2026-10-22-01-ai-script-secret-host-guard-runtime.md. AI runs with real secrets were only host-checked by regex.
• K1 (medium): 2026-10-20-01-sender-response-body-caps.md. Notification senders and RabbitMQ read responses uncapped.
• J1 (medium): 2026-10-19-01-a2a-response-size-cap.md. A2A responses were read uncapped.
• I1 (low): 2026-10-18-01-plugin-schema-file-ref.md. Plugin schema $ref could load local files.
• G1/G2 (low): 2026-10-17-01-postgres-check-connection-config.md. Postgres conninfo escaping and fallback to the worker's PG* env.
• F1: 2026-10-16-15-pat-cache-revocation.md. The PAT cache outlived revocation.
• E1: 2026-10-16-14-totp-on-federated-sign-in.md. No TOTP on federated sign-in.
• E2: 2026-10-16-13-atomic-auth-attempt-counters.md. Auth attempt counters were not atomic.
• H3: 2026-10-16-12-mcp-tokens-rejected-on-rest.md. MCP OAuth tokens worked on REST.
• H2: 2026-10-16-11-slack-signature-fail-closed.md. Slack signature check failed open.
• T1 / M2 (high): 2026-10-16-10-discovery-scans-egress-guard.md. Discovery scans were outside the egress policy.
• N4: 2026-10-16-09-js-check-nested-docker-guard.md. A JS docker sub-check bypassed the gate.
• N3 (high): 2026-10-16-08-status-page-components-cross-org.md. Status-page components could be edited across orgs.
• D2/D3 (high): 2026-10-16-07-guard-status-subscriber-and-publication-webhooks.md. Subscriber and publication webhooks were not guarded.
• C3: 2026-10-16-06-accept-invite-existing-account.md. Accepting an invite logged in as an existing account.
• C1: 2026-10-16-05-kubeconfig-exec-and-incluster.md. Kubeconfig exec and inCluster were allowed.
• N2: 2026-10-16-04-mysql-dsn-injection.md. MySQL DSN injection.
• N1: 2026-10-16-03-env-secret-reference-allowlist.md. No allowlist for ${env:} references.
• C2/H1: 2026-10-16-02-token-purpose-separation.md. Purpose tokens were accepted as access tokens.
• D1: 2026-10-16-01-microsoft-signin-unverified-email-linking.md. Microsoft nOAuth email linking.

🤖 Generated with Claude Code

[codecov]

Codecov Report

❌ Patch coverage is 95.50562% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.70%. Comparing base (0838916) to head (357506f).

Files with missing lines	Patch %	Lines
server/internal/handlers/auth/device_service.go	91.66%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #693      +/-   ##
==========================================
- Coverage   89.73%   89.70%   -0.04%     
==========================================
  Files        1292     1292              
  Lines      131726   131787      +61     
==========================================
+ Hits       118199   118213      +14     
- Misses      13518    13565      +47     
  Partials        9        9              

Files with missing lines	Coverage Δ
server/internal/db/models/device_auth.go	100.00% <ø> (ø)
server/internal/email/supportreply.go	92.68% <ø> (ø)
server/internal/handlers/auth/device_handler.go	80.28% <100.00%> (+1.49%)	⬆️
server/internal/handlers/auth/service.go	90.08% <100.00%> (+0.09%)	⬆️
server/internal/handlers/base/base.go	96.49% <100.00%> (+1.49%)	⬆️
server/internal/handlers/emailpreview/fixtures.go	100.00% <ø> (ø)
...internal/handlers/emailpreview/fixtures_account.go	100.00% <100.00%> (ø)
server/internal/middleware/ratelimit.go	85.37% <100.00%> (-0.97%)	⬇️
server/internal/handlers/auth/device_service.go	90.05% <91.66%> (+2.27%)	⬆️

... and 19 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.