Repository navigation
fix(spatial): handle SE2 angles that round to the period - #86
Open
Vamsi-2581 wants to merge 2 commits into
Open
Vamsi-2581 wants to merge 2 commits into
Vamsi-2581 wants to merge 2 commits into
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 6 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
huxiaoyi-ovo
left a comment
There was a problem hiding this comment.
I checked both the stored-angle and query-side wrapping against SciPy's periodic cKDTree, including the default SE2 metric and a weight of 0.3.
The boundary values now map correctly to zero, and both nearest-neighbour and radius queries return the expected vertex. Looks good from the code side.
CI is still waiting for maintainer approval, so that remains to be checked.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Normalize wrapped SE(2) angles that round to the period back to zero for both KD-tree data and query points. This prevents
scipy.spatial.cKDTreefrom rejecting coordinates when a tiny negative angle wraps to the period due to floating-point rounding.Tests
-1e-17, using named SE(2) and a weighted SE(2) metric.Fixes #85.