Repository navigation
fix(tests): build raw_coverage_all and inbound_linked_e2e against main - #8361
Merged
M3gA-Mind merged 2 commits intoOct 24, 2026
Merged
Conversation
…ontroller registry Main removed the `openhuman_core::storage::MemoryStorage` re-export, and `core::all::all_registered_controllers` now returns `ControllerEntry`s, so `raw_coverage_all` (and `inbound_linked_e2e`) stopped compiling: - E0433 tests/raw_coverage_all.rs:61, tests/inbound_linked_e2e.rs:51: install the testkit `MemoryBackend` the core's own tests use, via a new `tinystoragedrivers-testkit` dev-dependency of openhuman-cli (same rev). - E0308 tests/raw_coverage/inference_local_controllers_rpc_e2e.rs:219,473: look up and invoke core-registry entries through `ControllerEntry::invoke`.
Tiny Sweeper reviewReviewed head: Verdict: Ready for maintainer review · Priority: none Diagnostics and supporting detailsFull summaryPull request purpose (title): fix(tests): build raw_coverage_all and inbound_linked_e2e against main. Tiny Sweeper completed its review; deterministic results follow. Unreviewed paths
Review snapshot
Completeness: Complete What changedA `matches!` expression is reflowed by formatting. No product code is touched. Features
Tests
FindingsNo active actionable findings. Before mergeNone. Agent review detailscritique
security
tests
commits
description
Evidence and run details
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 3 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly identifies the test-focused fix and names the two primary test targets updated to build against the main branch. It does not mention the related controller-entry test changes, but th… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title clearly identifies the test-focused fix and names the two primary test targets updated to build against the main branch. It does not mention the related controller-entry test changes, but the title need not cover every change.
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit checks the testkit store,
Then finds an entry by its name.
It calls the core registry,
While local tests keep their old frame.
The burrow builds, the checks all run,
And carrots mark the work as done.
Comment @coderabbitai help to get the list of available commands.
![tinysweeper[bot]](https://avatars.githubusercontent.com/in/4526585?s=60&v=4){kind=small}
tinysweeper
Bot
added
the
priority: p3
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This was referenced Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main's
rust-core-coverageproduct-suites step doesn't compile. The errors were hidden behind earlier compile failures (key_source, shell_live, embed).tests/raw_coverage_all.rs:61andtests/inbound_linked_e2e.rs:51:openhuman_core::storage::MemoryStorageis no longer re-exported. The fix installstinystoragedrivers_testkit::MemoryBackendinstead, the same in-memory backend the core's own tests use (storage_host_tests.rs). It is added as an openhuman-cli dev-dependency at the rev the core already pins (one-lineCargo.lockchange).tests/raw_coverage/inference_local_controllers_rpc_e2e.rs:219,473:core::all::all_registered_controllersnow returnsVec<ControllerEntry>. The fix addsentry/call_entryhelpers that look up and invoke core-registry entries viaControllerEntry::invoke. The local-inference controllers keep using theRegisteredControllerhelpers.Test-only; no product code changes.
Test plan
cargo test --no-run -p openhuman-cli --test raw_coverage_allwith the core product features. RED on main 26fd9f8, GREEN on this head.cargo check --tests, keep going past errors) on the split-10 set plus this PR.Summary by CodeRabbit