Repository navigation
chore(vendor): move source-built vendor pins to each repo's main - #8325
Conversation
Moves these gitlinks forward to their repo's current main (each one a fast-forward): - vendor/tinystoragedrivers 05eaada -> f05fbd2, with the 12 tinystoragedrivers `rev =` pins in the cli, core, embed and rpc manifests kept equal to the gitlink - vendor/tinybus 2b2ac16 -> 809eef2 - vendor/tinymemory 6018a91 -> 8b919fd - vendor/tinyskills e330b68 -> d74e9d5 - vendor/tinyhumans-sdk 4f516fa -> f42b128 - vendor/tiny-artifacts e4aecbe -> 25a7cf9 Lockfiles follow in their own commit.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title "chore(vendor): move source-built vendor pins to each repo's main" matches the main change. The PR advances six vendor gitlinks and the 12 tinystoragedrivers rev pins in the manifests to the… |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Title check
-
Explanation
The title "chore(vendor): move source-built vendor pins to each repo's main" matches the main change. The PR advances six vendor gitlinks and the 12 tinystoragedrivers rev pins in the manifests to the new revisions. The title names the vendor pin update but does not mention the tinystoragedrivers manifest pins or the lockfile sync. Those are secondary details, so the title is accurate and specific enough.
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (10 skipped: 10 unsupported.)
✨ Finishing Touches: 💡 1
-
🛠️ Fix failing CI checks: 💡
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit checks the pins in place,
Then hops through commits at a steady pace.
The storage drivers find a newer home,
While tiny projects shift their roam.
The manifest rows now match the trail,
And carrot crumbs mark every nail.
Comment @coderabbitai help to get the list of available commands.
tiny-artifacts now depends on cap-std (already in both locks). The app lock also picks up tinydocs-bus 0.2.5, which was already on main's gitlink and root lock but missing from crates/openhuman-app/Cargo.lock. Regenerated with `cargo metadata` only, no `cargo update`; tokio stays at 1.54.1.
vendor/tinydocs and the root Cargo.lock are already at 0.2.5; the app lock still said 0.2.4, so cargo --locked refused it. Same line as tinyhumansai#8325, so the two merge cleanly in either order.
Tiny Sweeper reviewReviewed head: FindingsNo active actionable findings. Advisory notes
Verdict: Ready for maintainer review · Priority: none Diagnostics and supporting detailsFull summaryPull request purpose (title): chore(vendor): move source-built vendor pins to each repo's main. This PR is titled "chore(vendor): move source-built vendor pins to each repo's main" and described as moving source-built vendor pins so openhuman builds against every merged vendor change, with the 12 tinystoragedrivers `rev =` pins in openhuman-cli, openhuman-core, openhuman-embed and openhuman-rpc moving alongside the gitlink and the root `[patch]` still redirecting them to `vendor/tinystoragedrivers`. The evidence available for this review covers only four changed manifests — crates/openhuman-cli/Cargo.toml, crates/openhuman-core/Cargo.toml, crates/openhuman-embed/Cargo.toml, crates/openhuman-rpc/Cargo.toml — in which git dev-dependency revisions for `tinystoragedrivers`, `tinystoragedrivers-api`, `tinystoragedrivers-connect`, `tinystoragedrivers-types`, `tinystoragedrivers-secrets`, `tinystoragedrivers-bus`, `tinystoragedrivers-busproxy` and `tinystoragedrivers-testkit` are rewritten from `05eaada962decbab33bafa4763d2bd1a67f6b456` to `f05fbd230c2c403c8dcdef57316fa55265379039`. The description lane, which answered, flagged that the diff only moves the source-built tinystoragedrivers pins in four manifests and that the PR body's additional claims — gitlink moves for tinystoragedrivers/tinybus/tinymemory/tinyskills/tinyhumans-sdk/tiny-artifacts and lockfile changes including tiny-artifacts cap-std and tinydocs-bus 0.2.4 → 0.2.5 — do not appear in this diff, so the description overstates the change as written. Note the code index is behind this PR (indexed at b39fbd8), so retrieved context may be out of date. Unreviewed paths
Review snapshot
Completeness: Complete What changedThe changed manifests update the git `rev` pin for the source-built tinystoragedrivers crates from `05eaada962decbab33bafa4763d2bd1a67f6b456` to `f05fbd230c2c403c8dcdef57316fa55265379039`. In crates/openhuman-cli/Cargo.toml the dev-dependencies `tinystoragedrivers-api` and `tinystoragedrivers` (with `default-features = false, features = ["sqlite"]`) move to the new revision, which the critique lane notes is already the revision the core, embed, rpc and cli crates use. In crates/openhuman-core/Cargo.toml the same move is applied to `tinystoragedrivers`, `tinystoragedrivers-api`, `tinystoragedrivers-connect` (optional, features `["sqlite"]`), `tinystoragedrivers-types`, `tinystoragedrivers-secrets` (features `["document"]`), `tinystoragedrivers-bus`, `tinystoragedrivers-busproxy` and, in dev-dependencies, `tinystoragedrivers-testkit`. In crates/openhuman-embed/Cargo.toml `tinystoragedrivers-testkit` moves, and in crates/openhuman-rpc/Cargo.toml `tinystoragedrivers` (optional, features `["keyring"]`) moves. The whole-PR diffstat covers 12 files including lockfiles and vendor gitlinks, but the rendered evidence available here shows only these four manifest edits. Features
TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. Before mergeNone. Agent review detailscritique
security
tests
commits
description
Evidence and run details
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![tinysweeper[bot]](https://avatars.githubusercontent.com/in/4526585?s=60&v=4){kind=small}
tinysweeper
Bot
added
the
priority: p3
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Summary
Moves the source-built vendor pins to each repo's current main, so that openhuman builds against every merged vendor change. No vendor release is needed for these: openhuman builds them from the gitlinks.
vendor/tinystoragedrivers05eaadaf05fbd2vendor/tinybus2b2ac16809eef2vendor/tinymemory6018a918b919fdvendor/tinyskillse330b68d74e9d5vendor/tinyhumans-sdk4f516faf42b128vendor/tiny-artifactse4aecbe25a7cf9Every move is a fast-forward: each old pin is an ancestor of the new one. The 12 tinystoragedrivers
rev =pins inopenhuman-cli,openhuman-core,openhuman-embedandopenhuman-rpcmove with the gitlink. The root[patch]still redirects them tovendor/tinystoragedrivers.Manifest changes in these ranges, which explain the lockfile diff:
cap-std = "4"and the tokiortfeature.ureq3.3 → 3.5.tinystoragedrivers-busaversion = "2.1.0".vendor/tinyagentsis not moved here. Its current pined2880bcarries commits that tinyagents main lacks, including the wait tools thatopenhuman-coreimports. Those are being ported to tinyagents main first, and tinyagents follows via TA-MAIN-2325.Module repos (wallet, channels, juice, mcp, flows, …) are not part of this PR.
Status
rev =pinscrates/openhuman-app), regenerated withcargo metadataon the CI host. Only change:cap-stdon tiny-artifacts, plustinydocs-bus0.2.4 → 0.2.5 in the app lock, which was already on main's gitlink and root lock. tokio stays at 1.54.1.1e04926, no new failures against the main baseline9b3e2d8.vendor/tinyagents: follows via TA-MAIN-2325Tests
Checked on the shared CI host against a main baseline. Only failures that are new against main are attributed to this PR.
Summary by CodeRabbit